Takes - Acquire property toggle #3574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FuriousLlama
commented
Nov 6, 2023
| @@ -43,27 +43,6 @@ private AcquisitionFileService CreateAcquisitionServiceWithPermissions(params Pe | |||
| return this._helper.Create<AcquisitionFileService>(user); | |||
| } | |||
|
|
|||
| public static object[] takes = new List<object[]>() { | |||
There was a problem hiding this comment.
moved this section to be where the parametrized test is.
|
✅ No secrets were detected in the code. |
1 similar comment
|
✅ No secrets were detected in the code. |
Codecov Report
@@ Coverage Diff @@
## dev #3574 +/- ##
==========================================
+ Coverage 69.57% 69.59% +0.02%
==========================================
Files 1370 1370
Lines 33722 33751 +29
Branches 6273 6283 +10
==========================================
+ Hits 23462 23489 +27
- Misses 10009 10011 +2
Partials 251 251
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
minor placement issue, still may result in a bug.
|
devinleighsmith
approved these changes
Nov 6, 2023
|
✅ No secrets were detected in the code. |
|
✅ No secrets were detected in the code. |
|
✅ No secrets were detected in the code. |
|
✅ No secrets were detected in the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.