add automatic db deployment to test, uat. add keycloak sync to uat. update action definitions to allow for env specific secrets for keycloak sync. #3573

devinleighsmith · 2023-11-06T19:36:25Z

No description provided.

github-actions · 2023-11-06T19:38:22Z

✅ No secrets were detected in the code.

devinleighsmith · 2023-11-07T00:06:06Z

secret creation covered by: https://jira.th.gov.bc.ca/browse/PSP-7200

github-actions · 2023-11-07T00:25:56Z

✅ No secrets were detected in the code.

asanchezr · 2023-11-07T20:50:49Z

.github/workflows/ci-cd-pims-dev.yml

@@ -123,7 +123,7 @@ jobs:
      - name: call scripts to upgrade database
        shell: bash
        run: |
-          oc process -f ./openshift/4.0/templates/jobs/db-deploy.yaml -p SERVER_NAME=sqldevtst.th.gov.bc.ca -p DB_NAME=PIMS_DEV -p NAMESPACE=3cd915-dev | oc create -f - | grep -oP "(?<=job\.batch/)[^\s]*" | (read JOB_NAME; oc wait --for=condition=complete job/$JOB_NAME --timeout=120s)
+          oc process -f ./openshift/4.0/templates/jobs/db-deploy.yaml -p DB_SECRET_NAME=pims-database GIT_BRANCH=dev SERVER_NAME=sqldevtst.th.gov.bc.ca -p DB_NAME=PIMS_DEV -p NAMESPACE=3cd915-dev | oc create -f - | grep -oP "(?<=job\.batch/)[^\s]*" | (read JOB_NAME; oc wait --for=condition=complete job/$JOB_NAME --timeout=120s)


did you test this on OCP? According to OC documentation, template parameters need to be listed each with -p but I see this oc process ... -p DB_SECRET_NAME=... [-p needed here?] GIT_BRANCH=dev ...

I think you need to add -p in front of GIT_BRANCH and SERVER_NAME parameters - right? or does it work without it?

asanchezr · 2023-11-07T20:52:10Z

.github/workflows/retag-dev-to-test.yml

+          oc process -f ./openshift/4.0/templates/jobs/db-deploy.yaml -p DB_SECRET_NAME=pims-database-test GIT_BRANCH=dev SERVER_NAME=sqldevtst.th.gov.bc.ca -p DB_NAME=PIMS_TST -p NAMESPACE=3cd915-dev | oc create -f - | grep -oP "(?<=job\.batch/)[^\s]*" | (read JOB_NAME; oc wait --for=condition=complete job/$JOB_NAME --timeout=120s)
+


Same comment re: -p applies here

asanchezr · 2023-11-07T20:53:40Z

.github/workflows/retag-test-to-uat.yml

+      - name: call scripts to upgrade database
+        shell: bash
+        run: |
+          oc process -f ./openshift/4.0/templates/jobs/db-deploy.yaml -p DB_SECRET_NAME=pims-database GIT_BRANCH=test SERVER_NAME=sqlprd.th.gov.bc.ca -p DB_NAME=PIMS_UAT -p NAMESPACE=3cd915-test | oc create -f - | grep -oP "(?<=job\.batch/)[^\s]*" | (read JOB_NAME; oc wait --for=condition=complete job/$JOB_NAME --timeout=120s)


please check usage of -p here

asanchezr · 2023-11-07T20:58:12Z

.github/workflows/retag-test-to-uat.yml

+      - name: Install dependencies for keycloak sync
+        run: dotnet restore
+        working-directory: ${{env.sync-directory}}


The env-var sync-directory: ./tools/keycloak/sync is not present in this file like the others above. Please add it or kc-sync will fail in UAT

asanchezr

See comments

github-actions · 2023-11-07T22:26:36Z

✅ No secrets were detected in the code.

github-actions · 2023-11-07T22:26:46Z

✅ No secrets were detected in the code.

codecov · 2023-11-07T22:34:27Z

Codecov Report

Merging #3573 (119849f) into dev (795d389) will decrease coverage by 6.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev    #3573      +/-   ##
==========================================
- Coverage   69.57%   63.47%   -6.11%     
==========================================
  Files        1370      472     -898     
  Lines       33716    15141   -18575     
  Branches     6270     1026    -5244     
==========================================
- Hits        23458     9610   -13848     
+ Misses      10007     5280    -4727     
  Partials      251      251

Flag	Coverage Δ
unittests	`63.47% <100.00%> (-6.11%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...rce/backend/dal/Repositories/PropertyRepository.cs	`73.42% <100.00%> (ø)`

... and 898 files with indirect coverage changes

for testing purposes only, revert. typo. skip unecessary steps. temp. Revert "for testing purposes only, revert." This reverts commit 629967c. Revert "skip unecessary steps." This reverts commit bedc627.

github-actions · 2023-11-07T22:36:58Z

✅ No secrets were detected in the code.

github-actions · 2023-11-07T22:37:03Z

✅ No secrets were detected in the code.

devinleighsmith added the devops label Nov 6, 2023

devinleighsmith self-assigned this Nov 6, 2023

devinleighsmith mentioned this pull request Nov 6, 2023

psp-6988 File tabs fix #3575

Merged

devinleighsmith force-pushed the pipeline_enhancements branch from 884dc5a to 078f562 Compare November 7, 2023 00:23

asanchezr reviewed Nov 7, 2023

View reviewed changes

asanchezr approved these changes Nov 7, 2023

View reviewed changes

devinleighsmith force-pushed the pipeline_enhancements branch 2 times, most recently from 5f6048e to 23c0751 Compare November 7, 2023 22:24

devinleighsmith force-pushed the pipeline_enhancements branch from 23c0751 to 1710e3a Compare November 7, 2023 22:35

devinleighsmith added 3 commits November 7, 2023 14:35

add automatic db deployment to test.

3a25b7a

for testing purposes only, revert. typo. skip unecessary steps. temp. Revert "for testing purposes only, revert." This reverts commit 629967c. Revert "skip unecessary steps." This reverts commit bedc627.

code review comments.

ad2d318

test correction.

119849f

devinleighsmith force-pushed the pipeline_enhancements branch from 1710e3a to 119849f Compare November 7, 2023 22:35

devinleighsmith merged commit 7c953cb into bcgov:dev Nov 7, 2023
8 of 9 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add automatic db deployment to test, uat. add keycloak sync to uat. update action definitions to allow for env specific secrets for keycloak sync. #3573

add automatic db deployment to test, uat. add keycloak sync to uat. update action definitions to allow for env specific secrets for keycloak sync. #3573

devinleighsmith commented Nov 6, 2023

github-actions bot commented Nov 6, 2023

devinleighsmith commented Nov 7, 2023

github-actions bot commented Nov 7, 2023

asanchezr Nov 7, 2023

asanchezr Nov 7, 2023

asanchezr Nov 7, 2023

asanchezr Nov 7, 2023 •

edited

Loading

asanchezr left a comment

github-actions bot commented Nov 7, 2023

github-actions bot commented Nov 7, 2023

codecov bot commented Nov 7, 2023 •

edited

Loading

github-actions bot commented Nov 7, 2023

github-actions bot commented Nov 7, 2023

		oc process -f ./openshift/4.0/templates/jobs/db-deploy.yaml -p DB_SECRET_NAME=pims-database-test GIT_BRANCH=dev SERVER_NAME=sqldevtst.th.gov.bc.ca -p DB_NAME=PIMS_TST -p NAMESPACE=3cd915-dev \| oc create -f - \| grep -oP "(?<=job\.batch/)[^\s]*" \| (read JOB_NAME; oc wait --for=condition=complete job/$JOB_NAME --timeout=120s)

add automatic db deployment to test, uat. add keycloak sync to uat. update action definitions to allow for env specific secrets for keycloak sync. #3573

add automatic db deployment to test, uat. add keycloak sync to uat. update action definitions to allow for env specific secrets for keycloak sync. #3573

Conversation

devinleighsmith commented Nov 6, 2023

github-actions bot commented Nov 6, 2023

devinleighsmith commented Nov 7, 2023

github-actions bot commented Nov 7, 2023

asanchezr Nov 7, 2023

Choose a reason for hiding this comment

asanchezr Nov 7, 2023

Choose a reason for hiding this comment

asanchezr Nov 7, 2023

Choose a reason for hiding this comment

asanchezr Nov 7, 2023 • edited Loading

Choose a reason for hiding this comment

asanchezr left a comment

Choose a reason for hiding this comment

github-actions bot commented Nov 7, 2023

github-actions bot commented Nov 7, 2023

codecov bot commented Nov 7, 2023 • edited Loading

Codecov Report

github-actions bot commented Nov 7, 2023

github-actions bot commented Nov 7, 2023

asanchezr Nov 7, 2023 •

edited

Loading

codecov bot commented Nov 7, 2023 •

edited

Loading