PSP-7075 : Show ACQ team (organization) in project exports #3568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ No secrets were detected in the code. |
Codecov Report
@@ Coverage Diff @@
## dev #3568 +/- ##
==========================================
- Coverage 69.52% 69.52% -0.01%
==========================================
Files 1369 1369
Lines 33661 33687 +26
Branches 6260 6268 +8
==========================================
+ Hits 23404 23420 +16
- Misses 10005 10015 +10
Partials 252 252
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
✅ No secrets were detected in the code. |
| @@ -19,3 +22,22 @@ export enum ProjectExportTypes { | |||
| COMPENSATION = 'Compensation Requisition Export', | |||
| AGREEMENT = 'Agreement Export', | |||
| } | |||
|
|
|||
| const getParameterIdFromOptions = ( | |||
There was a problem hiding this comment.
would you mind moving this out to a shared method (since I think your last pr uses this as well). maybe in contactutils?
There was a problem hiding this comment.
different logic, this one returns an array, the other one returns a string. I thought about it.
devinleighsmith
approved these changes
Nov 3, 2023
|
✅ No secrets were detected in the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.