PSP-7069 : Show ACQ team (organization) in filter by ACQ team in Acqu… #3566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…isition List View
|
✅ No secrets were detected in the code. |
Codecov Report
@@ Coverage Diff @@
## dev #3566 +/- ##
==========================================
+ Coverage 69.51% 69.52% +0.01%
==========================================
Files 1369 1369
Lines 33634 33661 +27
Branches 6252 6260 +8
==========================================
+ Hits 23380 23404 +24
- Misses 10003 10005 +2
- Partials 251 252 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| @@ -206,14 +206,14 @@ public IActionResult GetAcquisitionFileOwners([FromRoute] long id) | |||
| [HasPermission(Permissions.AcquisitionFileView)] | |||
| [HasPermission(Permissions.ContactView)] | |||
| [Produces("application/json")] | |||
| [ProducesResponseType(typeof(IEnumerable<PersonModel>), 200)] | |||
| [ProducesResponseType(typeof(IEnumerable<AcquisitionFileTeamModel>), 200)] | |||
| [SwaggerOperation(Tags = new[] { "acquisitionfile" })] | |||
| public IActionResult GetAcquisitionTeamMembers() | |||
| { | |||
| // TODO: This endpoint needs to be fixed to support ORGANIZATIONS as team members (which were introduced by PSP-6960) | |||
There was a problem hiding this comment.
this todo appears to have been addressed, can it be removed?
| newModel.projectNameOrNumber = model.projectNameOrNumber; | ||
| newModel.searchBy = model.searchBy; | ||
| newModel.pin = model.pin; | ||
| newModel.pid = model.pid; | ||
| newModel.address = model.address; | ||
| console.log(model); |
There was a problem hiding this comment.
console.log and debugger should be removed.
| } | ||
|
|
||
| var filterOrgItems = options.filter(option => String(option.id).startsWith(selector)); | ||
| console.log(filterOrgItems); |
devinleighsmith
approved these changes
Nov 3, 2023
devinleighsmith
approved these changes
Nov 3, 2023
|
✅ No secrets were detected in the code. |
1 similar comment
|
✅ No secrets were detected in the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…isition List View