PSP-7039 Take SRW Expiry Date #3565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ No secrets were detected in the code. |
asanchezr
commented
Nov 2, 2023
| @@ -51,6 +52,8 @@ public void Register(TypeAdapterConfig config) | |||
| .Map(dest => dest.TakeTypeCode, src => src.TakeTypeCode) | |||
| .Map(dest => dest.TakeStatusTypeCode, src => src.TakeStatusTypeCode) | |||
| .Map(dest => dest.LandActTypeCode, src => src.LandActTypeCode.Id) | |||
| .Map(dest => dest.SrwEndDt, src => src.SrwEndDt) | |||
| .Map(dest => dest.IsAcquiredForInventory, () => true) // TODO: fix this | |||
There was a problem hiding this comment.
@FuriousLlama - you will have to fix this mapping in your PR
Codecov Report
@@ Coverage Diff @@
## dev #3565 +/- ##
=======================================
Coverage 69.50% 69.51%
=======================================
Files 1369 1369
Lines 33626 33634 +8
Branches 6250 6252 +2
=======================================
+ Hits 23371 23379 +8
Misses 10004 10004
Partials 251 251
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
✅ No secrets were detected in the code. |
FuriousLlama
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Unit tests will be added in an upcoming PR
Take Details
Take Update form