Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Psp 6988 - update property sidebar to use router instead of state. #3564

Merged
merged 6 commits into from
Nov 6, 2023

Conversation

devinleighsmith
Copy link
Collaborator

No description provided.

@devinleighsmith devinleighsmith added the enhancement New feature or request label Nov 2, 2023
@devinleighsmith devinleighsmith self-assigned this Nov 2, 2023
Copy link
Contributor

github-actions bot commented Nov 2, 2023

✅ No secrets were detected in the code.

@@ -120,10 +138,8 @@ export const MotiInventoryContainer: React.FunctionComponent<
onClose={props.onClose}
>
<>
<PropertyViewSelector
<PropertyRouter
composedPropertyState={composedPropertyState}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this composed property state might not be necessary anymore if the router can handle the expected state

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

composedPropertyState is maybe a misnomer. This is the object that contains all of the ltsa/property/bc assessment information, as well as the loading states for each. Still required.

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #3564 (0e7ecf4) into dev (bacf1b7) will increase coverage by 5.19%.
The diff coverage is 49.36%.

❗ Current head 0e7ecf4 differs from pull request most recent head ae26f6f. Consider uploading reports for the commit ae26f6f to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #3564      +/-   ##
==========================================
+ Coverage   69.54%   74.73%   +5.19%     
==========================================
  Files        1369      897     -472     
  Lines       33681    18527   -15154     
  Branches     6261     5218    -1043     
==========================================
- Hits        23423    13846    -9577     
+ Misses      10007     4681    -5326     
+ Partials      251        0     -251     
Flag Coverage Δ
unittests 74.73% <49.36%> (+5.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...pSideBar/acquisition/router/FilePropertyRouter.tsx 65.62% <ø> (ø)
...features/mapSideBar/property/PropertyContainer.tsx 100.00% <100.00%> (ø)
...ent/activity/detail/PropertyActivityDetailView.tsx 6.89% <ø> (ø)
...Management/detail/PropertyContactListContainer.tsx 68.75% <100.00%> (+62.50%) ⬆️
...ilsManagement/detail/PropertyManagementTabView.tsx 66.66% <ø> (-16.67%) ⬇️
...tail/summary/PropertyManagementDetailContainer.tsx 88.88% <100.00%> (-1.12%) ⬇️
...nt/detail/summary/PropertyManagementDetailView.tsx 100.00% <100.00%> (ø)
...tures/mapSideBar/router/PropertyActivityRouter.tsx 62.50% <ø> (ø)
...mapSideBar/shared/detail/PropertyFileContainer.tsx 100.00% <100.00%> (+13.88%) ⬆️
...ntend/src/features/mapSideBar/router/MapRouter.tsx 50.00% <0.00%> (ø)
... and 7 more

... and 493 files with indirect coverage changes

Copy link
Contributor

github-actions bot commented Nov 4, 2023

✅ No secrets were detected in the code.

@devinleighsmith devinleighsmith force-pushed the psp-6988 branch 2 times, most recently from ba5c911 to 1794ebc Compare November 6, 2023 07:07
Copy link
Contributor

github-actions bot commented Nov 6, 2023

✅ No secrets were detected in the code.

1 similar comment
Copy link
Contributor

github-actions bot commented Nov 6, 2023

✅ No secrets were detected in the code.

Copy link
Contributor

github-actions bot commented Nov 6, 2023

✅ No secrets were detected in the code.

1 similar comment
Copy link
Contributor

github-actions bot commented Nov 6, 2023

✅ No secrets were detected in the code.

@devinleighsmith devinleighsmith merged commit 705badf into bcgov:dev Nov 6, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants