-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Psp 6988 - update property sidebar to use router instead of state. #3564
Conversation
✅ No secrets were detected in the code. |
@@ -120,10 +138,8 @@ export const MotiInventoryContainer: React.FunctionComponent< | |||
onClose={props.onClose} | |||
> | |||
<> | |||
<PropertyViewSelector | |||
<PropertyRouter | |||
composedPropertyState={composedPropertyState} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this composed property state might not be necessary anymore if the router can handle the expected state
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
composedPropertyState is maybe a misnomer. This is the object that contains all of the ltsa/property/bc assessment information, as well as the loading states for each. Still required.
Codecov Report
@@ Coverage Diff @@
## dev #3564 +/- ##
==========================================
+ Coverage 69.54% 74.73% +5.19%
==========================================
Files 1369 897 -472
Lines 33681 18527 -15154
Branches 6261 5218 -1043
==========================================
- Hits 23423 13846 -9577
+ Misses 10007 4681 -5326
+ Partials 251 0 -251
Flags with carried forward coverage won't be shown. Click here to find out more.
|
0e7ecf4
to
ea54a46
Compare
✅ No secrets were detected in the code. |
ba5c911
to
1794ebc
Compare
✅ No secrets were detected in the code. |
1 similar comment
✅ No secrets were detected in the code. |
d1fbecd
to
ae26f6f
Compare
✅ No secrets were detected in the code. |
1 similar comment
✅ No secrets were detected in the code. |
No description provided.