Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Psp 7128 fix table pagination when table size prop is supplied. #3559

Merged
merged 3 commits into from
Nov 6, 2023

Conversation

devinleighsmith
Copy link
Collaborator

No description provided.

@devinleighsmith devinleighsmith self-assigned this Oct 31, 2023
@devinleighsmith devinleighsmith added the bug Something isn't working label Oct 31, 2023
Copy link
Contributor

✅ No secrets were detected in the code.

1 similar comment
Copy link
Contributor

github-actions bot commented Nov 1, 2023

✅ No secrets were detected in the code.

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #3559 (0ac9999) into dev (973a939) will increase coverage by 11.13%.
The diff coverage is 100.00%.

❗ Current head 0ac9999 differs from pull request most recent head 3680e13. Consider uploading reports for the commit 3680e13 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##              dev    #3559       +/-   ##
===========================================
+ Coverage   63.41%   74.54%   +11.13%     
===========================================
  Files         472      897      +425     
  Lines       15137    18545     +3408     
  Branches     1025     5237     +4212     
===========================================
+ Hits         9599    13825     +4226     
+ Misses       5287     4720      -567     
+ Partials      251        0      -251     
Flag Coverage Δ
unittests 74.54% <100.00%> (+11.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...frontend/src/components/Table/PageSizeSelector.tsx 100.00% <ø> (ø)
source/frontend/src/components/Table/Table.tsx 80.07% <100.00%> (ø)
...documents/list/DocumentResults/DocumentResults.tsx 100.00% <ø> (ø)

... and 1366 files with indirect coverage changes

Copy link
Contributor

github-actions bot commented Nov 6, 2023

✅ No secrets were detected in the code.

Copy link
Contributor

github-actions bot commented Nov 6, 2023

✅ No secrets were detected in the code.

@devinleighsmith devinleighsmith merged commit bc4e6f0 into bcgov:dev Nov 6, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants