Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

psp-7095 add default status to new management activities, display sta… #3558

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

devinleighsmith
Copy link
Collaborator

…tus as required field.

@devinleighsmith devinleighsmith added the bug Something isn't working label Oct 31, 2023
@devinleighsmith devinleighsmith self-assigned this Oct 31, 2023
Copy link
Contributor

✅ No secrets were detected in the code.

Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #3558 (c1602c1) into dev (bc4e6f0) will decrease coverage by 4.97%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #3558      +/-   ##
==========================================
- Coverage   74.52%   69.56%   -4.97%     
==========================================
  Files         897     1369     +472     
  Lines       18570    33711   +15141     
  Branches     5239     6265    +1026     
==========================================
+ Hits        13840    23450    +9610     
- Misses       4730    10010    +5280     
- Partials        0      251     +251     
Flag Coverage Δ
unittests 69.56% <100.00%> (-4.97%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
source/backend/api/Services/PropertyService.cs 59.41% <100.00%> (ø)
...agement/activity/edit/PropertyActivityEditForm.tsx 5.12% <ø> (ø)

... and 471 files with indirect coverage changes

Copy link
Contributor

github-actions bot commented Nov 6, 2023

✅ No secrets were detected in the code.

Copy link
Contributor

github-actions bot commented Nov 6, 2023

✅ No secrets were detected in the code.

@devinleighsmith devinleighsmith merged commit 34d0f09 into bcgov:dev Nov 6, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants