Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

psp-7084 fix the add an activity icon in management. #3557

Merged
merged 6 commits into from
Nov 6, 2023

Conversation

devinleighsmith
Copy link
Collaborator

No description provided.

@devinleighsmith devinleighsmith added the bug Something isn't working label Oct 31, 2023
@devinleighsmith devinleighsmith self-assigned this Oct 31, 2023
Copy link
Contributor

✅ No secrets were detected in the code.

Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #3557 (42a0285) into dev (310df85) will increase coverage by 4.91%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #3557      +/-   ##
==========================================
+ Coverage   69.56%   74.48%   +4.91%     
==========================================
  Files        1369      897     -472     
  Lines       33711    18563   -15148     
  Branches     6265     5238    -1027     
==========================================
- Hits        23450    13826    -9624     
+ Misses      10010     4737    -5273     
+ Partials      251        0     -251     
Flag Coverage Δ
unittests 74.48% <60.00%> (+4.91%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ontend/src/components/common/SectionListHeader.tsx 100.00% <ø> (ø)
...on/tabs/compensation/list/CompensationListView.tsx 85.71% <ø> (ø)
...bs/expropriation/ExpropriationTabContainerView.tsx 69.56% <ø> (ø)
...ent/activity/list/ManagementActivitiesListView.tsx 58.33% <ø> (ø)
...tailsManagement/detail/PropertyContactListView.tsx 45.45% <ø> (ø)
source/frontend/src/utils/YupSchema.ts 100.00% <ø> (ø)
...c/features/mapSideBar/acquisition/common/models.ts 83.76% <50.00%> (-0.73%) ⬇️
.../src/features/properties/filter/PropertyFilter.tsx 51.72% <66.66%> (-9.00%) ⬇️

... and 472 files with indirect coverage changes

Copy link
Contributor

github-actions bot commented Nov 3, 2023

✅ No secrets were detected in the code.

1 similar comment
Copy link
Contributor

github-actions bot commented Nov 4, 2023

✅ No secrets were detected in the code.

Copy link
Contributor

github-actions bot commented Nov 4, 2023

✅ No secrets were detected in the code.

Copy link
Contributor

github-actions bot commented Nov 6, 2023

✅ No secrets were detected in the code.

Copy link
Contributor

github-actions bot commented Nov 6, 2023

✅ No secrets were detected in the code.

Copy link
Contributor

github-actions bot commented Nov 6, 2023

✅ No secrets were detected in the code.

1 similar comment
Copy link
Contributor

github-actions bot commented Nov 6, 2023

✅ No secrets were detected in the code.

@devinleighsmith devinleighsmith merged commit 8c4ad76 into bcgov:dev Nov 6, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants