psp-6984 add support for activity documents #3554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ No secrets were detected in the code. |
Codecov Report
@@ Coverage Diff @@
## dev #3554 +/- ##
==========================================
+ Coverage 69.22% 69.27% +0.04%
==========================================
Files 1370 1370
Lines 33539 33597 +58
Branches 6233 6238 +5
==========================================
+ Hits 23218 23274 +56
- Misses 10071 10072 +1
- Partials 250 251 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| #region Methods | ||
|
|
||
| /// <summary> | ||
| /// Get a list of all the document file relationships for a a given acquisition file. |
There was a problem hiding this comment.
for a given property activity
| /// Get a list of all the document file relationships for a a given acquisition file. | ||
| /// </summary> | ||
| /// <returns></returns> | ||
| public IList<PimsPropertyActivityDocument> GetAllByPropertyActivityFile(long fileId) |
There was a problem hiding this comment.
variable and method naming looks copy pasted?
fileId => activityId | propertyActivityId
GetAllByPropertyActivityFile => GetAllByPropertyActivity
FuriousLlama
approved these changes
Oct 31, 2023
|
✅ No secrets were detected in the code. |
1 similar comment
|
✅ No secrets were detected in the code. |
devinleighsmith
force-pushed
the
psp-6984
branch
from
01983ab to
03abae6
Compare
|
✅ No secrets were detected in the code. |
1 similar comment
|
✅ No secrets were detected in the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.