psp-7034 add warning when interest holders attached to acquisition pr… #3550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ No secrets were detected in the code. |
Codecov Report
@@ Coverage Diff @@
## dev #3550 +/- ##
==========================================
- Coverage 69.30% 63.05% -6.25%
==========================================
Files 1370 471 -899
Lines 33538 15040 -18498
Branches 6229 1019 -5210
==========================================
- Hits 23242 9483 -13759
+ Misses 10046 5307 -4739
Partials 250 250
Flags with carried forward coverage won't be shown. Click here to find out more.
|
asanchezr
reviewed
Oct 27, 2023
Comment on lines
+299
to
+301
| if (acqFileProperties.PimsTakes.Any() || acqFileProperties.PimsInthldrPropInterests.Any()) | ||
| { | ||
| throw new BusinessRuleViolationException(); | ||
| throw new BusinessRuleViolationException("You must remove all takes and interest holders from an acquisition file property before removing that property from an acquisition file"); |
There was a problem hiding this comment.
nit: would love to see a unit test covering this bug fix
asanchezr
approved these changes
Oct 27, 2023
…operty being deleted.
devinleighsmith
force-pushed
the
psp-7034
branch
from
e384367 to
4fc9107
Compare
|
✅ No secrets were detected in the code. |
|
✅ No secrets were detected in the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…operty being deleted.