Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSP-7032 : FT:HelpDesk:Header UI(Font and Icon size) is not displaying accurately for Help and User text #3539

Merged
merged 3 commits into from
Oct 27, 2023

Conversation

eddherrera
Copy link
Collaborator

PSP-7057 : FT:HelpDesk: map icon is not close PIMS naming on the Header

@eddherrera eddherrera added the bug Something isn't working label Oct 24, 2023
@eddherrera eddherrera self-assigned this Oct 24, 2023
@github-actions
Copy link
Contributor

✅ No secrets were detected in the code.

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #3539 (d95a972) into dev (b99a18d) will increase coverage by 4.93%.
The diff coverage is 100.00%.

❗ Current head d95a972 differs from pull request most recent head 89896ba. Consider uploading reports for the commit 89896ba to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #3539      +/-   ##
==========================================
+ Coverage   68.96%   73.89%   +4.93%     
==========================================
  Files        1370      898     -472     
  Lines       33519    18440   -15079     
  Branches     6218     5191    -1027     
==========================================
- Hits        23117    13627    -9490     
+ Misses      10152     4813    -5339     
+ Partials      250        0     -250     
Flag Coverage Δ
unittests 73.89% <100.00%> (+4.93%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...e/frontend/src/components/layout/Header/Header.tsx 90.90% <100.00%> (+0.43%) ⬆️
...tend/src/components/layout/Header/HeaderStyled.tsx 100.00% <ø> (ø)
...ntend/src/components/layout/Header/UserProfile.tsx 83.33% <100.00%> (ø)
...end/src/features/help/containers/HelpContainer.tsx 90.90% <ø> (ø)

... and 488 files with indirect coverage changes

@devinleighsmith
Copy link
Collaborator

Well, the help icon doesn't match still, is that a problem? (see figma)

@github-actions
Copy link
Contributor

✅ No secrets were detected in the code.

@asanchezr asanchezr merged commit 0f1a2ae into bcgov:dev Oct 27, 2023
7 checks passed
@eddherrera eddherrera deleted the psp-7032 branch November 1, 2023 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants