Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PSP-6865 Property Management summary #3499

Merged
merged 25 commits into from
Oct 5, 2023
Merged

PSP-6865 Property Management summary #3499

merged 25 commits into from
Oct 5, 2023

Conversation

asanchezr
Copy link
Collaborator

Screenshot 2023-09-28 160625

@asanchezr asanchezr added the enhancement New feature or request label Oct 3, 2023
@asanchezr asanchezr self-assigned this Oct 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2023

✅ No secrets were detected in the code.

@codecov
Copy link

codecov bot commented Oct 3, 2023 •
edited
Loading

Codecov Report

Merging #3499 (4270c53) into dev (fb1809f) will increase coverage by 0.08%.
The diff coverage is 84.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #3499      +/-   ##
==========================================
+ Coverage   71.42%   71.50%   +0.08%     
==========================================
  Files        1343     1351       +8     
  Lines       31710    31869     +159     
  Branches     5977     6005      +28     
==========================================
+ Hits        22648    22789     +141     
- Misses       8818     8833      +15     
- Partials      244      247       +3
Flag Coverage Δ
unittests 71.50% <84.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...i/Areas/Property/Controllers/PropertyController.cs 65.21% <100.00%> (+8.07%) ⬆️
source/backend/api/Controllers/LookupController.cs 100.00% <100.00%> (ø)
.../Models/Concepts/Property/PropertyManagementMap.cs 100.00% <100.00%> (ø)
.../Concepts/Property/PropertyManagementPurposeMap.cs 100.00% <100.00%> (ø)
...ackend/api/Models/Concepts/Property/PropertyMap.cs 100.00% <ø> (ø)
...rce/backend/dal/Repositories/PropertyRepository.cs 57.19% <100.00%> (+2.10%) ⬆️
source/frontend/src/constants/API.ts 100.00% <100.00%> (ø)
...ilsManagement/detail/PropertyManagementTabView.tsx 66.66% <ø> (ø)
...nt/detail/summary/PropertyManagementDetailView.tsx 71.42% <100.00%> (ø)
...nt/update/summary/PropertyManagementUpdateForm.tsx 100.00% <100.00%> (ø)
... and 13 more

... and 2 files with indirect coverage changes

@asanchezr asanchezr force-pushed the psp-6865-management-summary branch from 8f3339f to 55818fe Compare October 4, 2023 04:09
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

✅ No secrets were detected in the code.

@devinleighsmith
Copy link
Collaborator

THe property purpose appears to default to other but I don't see that in the requirements.

@devinleighsmith
Copy link
Collaborator

Not sure, but some of the implemented functionality appears to correlate to a crossed out section in confluence.

image

not sure if that logic should be in there or not.

@asanchezr asanchezr force-pushed the psp-6865-management-summary branch from 55818fe to c3b6690 Compare October 4, 2023 22:41
@asanchezr
Copy link
Collaborator Author

Not sure, but some of the implemented functionality appears to correlate to a crossed out section in confluence.

image

not sure if that logic should be in there or not.

hmm - this was done after I implemented and demoed the story to the business. So I assume any changes will come in an additional story. Would be ideal if BAs used confluence versioning properly

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

✅ No secrets were detected in the code.

@asanchezr
Copy link
Collaborator Author

THe property purpose appears to default to other but I don't see that in the requirements.

Sorry, I don't follow. AFAIK, the property purposes (plural) is an array (ie multi-select) and it default to the empty array. What is implemented (and called out in Confluence) is that if that array contains the code OTHER, then the additional details textarea is required

@asanchezr
Refactor internal VIEW/EDIT state
5b7a46a
@asanchezr
WIP
016b273
@asanchezr
Extract property management info into own model
863e8e2
@asanchezr
Property management backend changes
979e99d 
- Move endpoints to new controller
- Send flags with response for active lease status and expiry date
- Remove lease-view permissions from management endpoints
- Add management methods to Property Service
@asanchezr
Add new lookup code for property management purpose
dace01c
@asanchezr
Fix mapping
85c90ed
@asanchezr
Enforce null values in backend controller
115d4b5
@asanchezr asanchezr force-pushed the psp-6865-management-summary branch from c3b6690 to 4270c53 Compare October 4, 2023 23:29
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

✅ No secrets were detected in the code.

@asanchezr asanchezr merged commit cdae840 into bcgov:dev Oct 5, 2023
8 of 9 checks passed
@asanchezr asanchezr deleted the psp-6865-management-summary branch October 6, 2023 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devinleighsmith devinleighsmith devinleighsmith approved these changes

@FuriousLlama FuriousLlama Awaiting requested review from FuriousLlama

@stairaku stairaku Awaiting requested review from stairaku

@PryancaJSharma PryancaJSharma Awaiting requested review from PryancaJSharma

@eddherrera eddherrera Awaiting requested review from eddherrera

@buddy326 buddy326 Awaiting requested review from buddy326

Assignees

@asanchezr asanchezr

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asanchezr @devinleighsmith