PR feedback

bcgov · Oct 4, 2023 · 4270c53 · 4270c53
1 parent ab1acf9
commit 4270c53
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 17 deletions.
diff --git a/source/backend/api/Areas/Property/Controllers/PropertyManagementController.cs b/source/backend/api/Areas/Property/Controllers/PropertyManagementController.cs
@@ -42,7 +42,7 @@ public PropertyManagementController(IPropertyService propertyService, IMapper ma
         /// </summary>
         /// <returns></returns>
         [HttpGet("{propertyId}/management")]
-        [HasPermission(Permissions.PropertyView)]
+        [HasPermission(Permissions.ManagementView)]
         [Produces("application/json")]
         [ProducesResponseType(typeof(PropertyManagementModel), 200)]
         [SwaggerOperation(Tags = new[] { "property" })]
@@ -57,7 +57,7 @@ public IActionResult GetPropertyManagement(long propertyId)
         /// </summary>
         /// <returns></returns>
         [HttpPut("{propertyId}/management")]
-        [HasPermission(Permissions.PropertyEdit)]
+        [HasPermission(Permissions.ManagementEdit)]
         [Produces("application/json")]
         [ProducesResponseType(typeof(PropertyManagementModel), 200)]
         [SwaggerOperation(Tags = new[] { "property" })]

diff --git a/.../tabs/propertyDetailsManagement/update/summary/PropertyManagementUpdateContainer.test.tsx b/.../tabs/propertyDetailsManagement/update/summary/PropertyManagementUpdateContainer.test.tsx
@@ -79,11 +79,6 @@ describe('PropertyManagementUpdateContainer component', () => {
     jest.clearAllMocks();
   });
 
-  it('renders as expected', () => {
-    const { asFragment } = setup();
-    expect(asFragment()).toMatchSnapshot();
-  });
-
   it('fetches property management info from the api', () => {
     mockGetApi.execute.mockResolvedValue(getMockApiPropertyManagement(1));
     setup({ props: { propertyId: 1 } });

diff --git a/...lsManagement/update/summary/__snapshots__/PropertyManagementUpdateContainer.test.tsx.snap b/...lsManagement/update/summary/__snapshots__/PropertyManagementUpdateContainer.test.tsx.snap