Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIMS-2258 Adjust when property agency changes are restricted #2886

Merged
merged 4 commits into from
Dec 19, 2024

Conversation

dbarkowsky
Copy link
Collaborator

🎯 Summary

PIMS-2258

Changes

  • Added some comments
  • Added a condition to the if statement that controls if an agency change is denied for properties
    • It will now check that an agency was included in the request before checking if a user has permissions for that agency

Testing

  • As a General User, try to add/update assessment values for a property in your agencies.

🔰 Checklist

  • I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.

Copy link

🚀 Deployment Information

The Express API Image has been built with the tag: 2886. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the API deployment. For more updates please monitor Image Tags Page on Wiki.

Copy link
Collaborator

@Sharala-Perumal Sharala-Perumal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a general user, I can now update or add new assessment values to the properties within my agency.

@dbarkowsky dbarkowsky merged commit 5acba61 into main Dec 19, 2024
8 checks passed
@dbarkowsky dbarkowsky deleted the PIMS-2258 branch December 19, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants