From 45cc048728d1b4bac196e6f4c299ac9f25b53dd7 Mon Sep 17 00:00:00 2001
From: Trevor Richards <trev@trevdev.ca>
Date: Fri, 1 Nov 2024 15:21:16 -0700
Subject: [PATCH 1/5] fix: broken expansion panels in printable view

---
 .../src/components/SummaryDeclaration.vue     | 38 ++++++++++---------
 1 file changed, 21 insertions(+), 17 deletions(-)

diff --git a/frontend/src/components/SummaryDeclaration.vue b/frontend/src/components/SummaryDeclaration.vue
index ec12b1b5d..725997a5b 100644
--- a/frontend/src/components/SummaryDeclaration.vue
+++ b/frontend/src/components/SummaryDeclaration.vue
@@ -76,7 +76,7 @@
               <v-card-title class="rounded-t-lg pt-3 pb-3 card-title" style="color: #003466"> Summary </v-card-title>
             </v-col>
           </v-row>
-          <v-expansion-panels ref="v-expansion-panels" v-model="expand" multiple variant="accordion">
+          <v-expansion-panels v-model="expand" multiple variant="accordion">
             <v-row v-if="isMainLoading">
               <v-col>
                 <v-skeleton-loader
@@ -88,7 +88,7 @@
             </v-row>
             <v-row v-else no-gutters class="d-flex flex-column pb-2 pt-2">
               <div v-if="!isRenewal">
-                <v-expansion-panel variant="accordion">
+                <v-expansion-panel variant="accordion" value="organization-summary">
                   <OrganizationSummary
                     :program-year="formattedProgramYear"
                     :summary-model="summaryModel"
@@ -107,7 +107,7 @@
                 />
 
                 <div v-else>
-                  <v-expansion-panel v-if="facility?.facilityInfo" variant="accordion">
+                  <v-expansion-panel v-if="facility?.facilityInfo" variant="accordion" value="facility-information">
                     <FacilityInformationSummary
                       :facility-info="facility?.facilityInfo"
                       :funding="facility?.funding"
@@ -121,7 +121,7 @@
                       @is-summary-valid="isFormComplete"
                     />
                   </v-expansion-panel>
-                  <v-expansion-panel variant="accordion">
+                  <v-expansion-panel variant="accordion" value="ccof-summary">
                     <div v-if="!facility.funding || isRenewal" />
                     <div v-else>
                       <CCOFSummaryFamily
@@ -141,7 +141,7 @@
                       />
                     </div>
                   </v-expansion-panel>
-                  <v-expansion-panel variant="accordion">
+                  <v-expansion-panel variant="accordion" value="ccfri-summary">
                     <CCFRISummary
                       :ccfri="facility?.ccfri"
                       :facility-id="facility.facilityId"
@@ -150,7 +150,7 @@
                       @is-summary-valid="isFormComplete"
                     />
                   </v-expansion-panel>
-                  <v-expansion-panel v-if="facility?.rfiApp" variant="accordion">
+                  <v-expansion-panel v-if="facility?.rfiApp" variant="accordion" value="rfi-summary">
                     <RFISummary
                       :rfi-app="facility?.rfiApp"
                       :ccfri-id="facility?.ccfri?.ccfriId"
@@ -160,7 +160,7 @@
                       @is-summary-valid="isFormComplete"
                     />
                   </v-expansion-panel>
-                  <v-expansion-panel v-if="facility?.nmfApp" variant="accordion">
+                  <v-expansion-panel v-if="facility?.nmfApp" variant="accordion" value="nmf-summary">
                     <NMFSummary
                       :nmf-app="facility?.nmfApp"
                       :ccfri-id="facility?.ccfri?.ccfriId"
@@ -170,7 +170,7 @@
                       @is-summary-valid="isFormComplete"
                     />
                   </v-expansion-panel>
-                  <v-expansion-panel variant="accordion">
+                  <v-expansion-panel variant="accordion" value="ecewe-summary-a">
                     <ECEWESummary
                       :ecewe="{}"
                       :ecewe-facility="facility.ecewe"
@@ -180,7 +180,7 @@
                       @is-summary-valid="isFormComplete"
                     />
                   </v-expansion-panel>
-                  <v-expansion-panel variant="accordion">
+                  <v-expansion-panel variant="accordion" value="uploaded-documents-summary">
                     <UploadedDocumentsSummary
                       :documents="facility.documents"
                       :program-year-id="summaryModel?.application?.programYearId"
@@ -190,7 +190,7 @@
                 </div>
               </div>
               <div v-if="!isRenewal" class="mt-10">
-                <v-expansion-panel variant="accordion">
+                <v-expansion-panel variant="accordion" value="ecewe-summary-b">
                   <ECEWESummary
                     :ecewe="summaryModel.ecewe"
                     :ecewe-facility="null"
@@ -588,9 +588,6 @@ export default {
         return facility.facilityInfo.facilityAccountNumber;
       });
     },
-    numberOfPanelsToExpand() {
-      return this.$refs['v-expansion-panels']?.$children.length;
-    },
     hasChangeNotificationFormDocuments() {
       return this.summaryModel?.changeRequestTypes?.includes(CHANGE_REQUEST_TYPES.PDF_CHANGE);
     },
@@ -611,7 +608,6 @@ export default {
       handler: function (val) {
         if (val) {
           setTimeout(() => {
-            console.log(this.$refs['v-expansion-panels']);
             const keys = Object.keys(this.payload);
             console.log('calling after 1 second');
             //If this is a change request, we'll have 2 items in the payload.
@@ -817,9 +813,17 @@ export default {
       this.updateNavBarStatus(formObj, isComplete);
     },
     expandAllPanels() {
-      for (let i = 0; i < this.numberOfPanelsToExpand; i++) {
-        this.expand.push(i);
-      }
+      this.expand = [
+        'organization-summary',
+        'facility-information',
+        'ccof-summary',
+        'ccfri-summary',
+        'rfi-summary',
+        'nmf-summary',
+        'ecewe-summary-a',
+        'ecewe-summary-b',
+        'uploaded-documents-summary',
+      ];
     },
     updateNavBarStatus(formObj, isComplete) {
       if (formObj && !this.isReadOnly) {

From d4bea92c8e52a645c876712e1347937e1ddb8859 Mon Sep 17 00:00:00 2001
From: Trevor Richards <trev@trevdev.ca>
Date: Fri, 1 Nov 2024 15:21:36 -0700
Subject: [PATCH 2/5] fix: ul padding & margin

---
 frontend/src/components/SummaryDeclaration.vue | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/frontend/src/components/SummaryDeclaration.vue b/frontend/src/components/SummaryDeclaration.vue
index 725997a5b..776d999a1 100644
--- a/frontend/src/components/SummaryDeclaration.vue
+++ b/frontend/src/components/SummaryDeclaration.vue
@@ -242,7 +242,7 @@
                   I hereby confirm that the information I have provided in this application is complete and accurate. I
                   certify that I have read and understand the following requirements:
                 </p>
-                <ul style="padding-top: 10px">
+                <ul class="ml-5 pt-5">
                   <li>Each facility must be licensed under the Community Care and Assisted Living Act;</li>
                   <li>
                     Each facility must be in compliance with the Community Care and Assisted Living Act and Child Care

From 545c7cae429692354da2d8887fd816258fac4e7f Mon Sep 17 00:00:00 2001
From: Trevor Richards <trev@trevdev.ca>
Date: Fri, 1 Nov 2024 16:53:53 -0700
Subject: [PATCH 3/5] fix: printable expansion panels in change request

---
 .../SummaryDeclarationChangeRequest.vue       | 21 ++++++++++++-------
 1 file changed, 14 insertions(+), 7 deletions(-)

diff --git a/frontend/src/components/requestChanges/SummaryDeclarationChangeRequest.vue b/frontend/src/components/requestChanges/SummaryDeclarationChangeRequest.vue
index 1a725246a..4472e6f03 100644
--- a/frontend/src/components/requestChanges/SummaryDeclarationChangeRequest.vue
+++ b/frontend/src/components/requestChanges/SummaryDeclarationChangeRequest.vue
@@ -82,7 +82,12 @@
             >
               <v-row no-gutters class="d-flex flex-column mb-2">
                 <!-- Change Notification Form Summary -->
-                <v-expansion-panel v-if="hasChangeRequestType('PDF_CHANGE')" variant="accordion" class="mb-8 mt-8">
+                <v-expansion-panel
+                  v-if="hasChangeRequestType('PDF_CHANGE')"
+                  variant="accordion"
+                  class="mb-8 mt-8"
+                  value="change-notification-form-summary"
+                >
                   <ChangeNotificationFormSummary
                     :change-notification-form-documents="summaryModel?.changeNotificationFormDocuments"
                     @is-summary-valid="isFormComplete"
@@ -98,7 +103,7 @@
                       type="paragraph, text@3, paragraph, text@3, paragraph"
                     />
                     <div v-else>
-                      <v-expansion-panel variant="accordion">
+                      <v-expansion-panel variant="accordion" value="facility-name">
                         <v-row no-gutters class="d-flex pl-6 py-5">
                           <v-col class="col-6 col-lg-4">
                             <p class="summary-label">Facility Name</p>
@@ -120,7 +125,7 @@
                           </v-col>
                         </v-row>
                       </v-expansion-panel>
-                      <v-expansion-panel variant="accordion">
+                      <v-expansion-panel variant="accordion" value="mtfi-summary">
                         <MTFISummary
                           v-if="hasChangeRequestType('MTFI') && !isSummaryLoading[index]"
                           :old-ccfri="facility?.oldCcfri"
@@ -129,7 +134,11 @@
                           @is-summary-valid="isFormComplete"
                         />
                       </v-expansion-panel>
-                      <v-expansion-panel v-if="facility?.hasRfi && !isSummaryLoading[index]" variant="accordion">
+                      <v-expansion-panel
+                        v-if="facility?.hasRfi && !isSummaryLoading[index]"
+                        variant="accordion"
+                        name="rfi-summary"
+                      >
                         <RFISummary
                           :rfi-app="facility?.rfiApp"
                           :ccfri-id="facility?.ccfriApplicationId"
@@ -488,9 +497,7 @@ export default {
       'setDeclarationModel',
     ]),
     expandAllPanels() {
-      for (let i = 0; i < this.numberOfPanelsToExpand; i++) {
-        this.expand.push(i);
-      }
+      this.expand = ['change-notification-form-summary', 'facility-name', 'mtfi-summary', 'rfi-summary'];
     },
     isPageComplete() {
       if (this.model.agreeConsentCertify && this.model.orgContactName && this.isSummaryComplete) {

From 673e3b4eede9a8071dd13de426e767ecdbff78fc Mon Sep 17 00:00:00 2001
From: Trevor Richards <trev@trevdev.ca>
Date: Mon, 4 Nov 2024 09:41:31 -0800
Subject: [PATCH 4/5] fix: name attr should be value

---
 .../requestChanges/SummaryDeclarationChangeRequest.vue          | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/frontend/src/components/requestChanges/SummaryDeclarationChangeRequest.vue b/frontend/src/components/requestChanges/SummaryDeclarationChangeRequest.vue
index 4472e6f03..4ab0f420c 100644
--- a/frontend/src/components/requestChanges/SummaryDeclarationChangeRequest.vue
+++ b/frontend/src/components/requestChanges/SummaryDeclarationChangeRequest.vue
@@ -137,7 +137,7 @@
                       <v-expansion-panel
                         v-if="facility?.hasRfi && !isSummaryLoading[index]"
                         variant="accordion"
-                        name="rfi-summary"
+                        value="rfi-summary"
                       >
                         <RFISummary
                           :rfi-app="facility?.rfiApp"

From 1934d93a12131217722f85a852dbe850e420cd52 Mon Sep 17 00:00:00 2001
From: Trevor Richards <trev@trevdev.ca>
Date: Mon, 4 Nov 2024 12:01:20 -0800
Subject: [PATCH 5/5] fix: dead code

---
 .../requestChanges/SummaryDeclarationChangeRequest.vue        | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/frontend/src/components/requestChanges/SummaryDeclarationChangeRequest.vue b/frontend/src/components/requestChanges/SummaryDeclarationChangeRequest.vue
index 4ab0f420c..57451d814 100644
--- a/frontend/src/components/requestChanges/SummaryDeclarationChangeRequest.vue
+++ b/frontend/src/components/requestChanges/SummaryDeclarationChangeRequest.vue
@@ -72,7 +72,6 @@
           </v-row>
           <div v-else>
             <v-expansion-panels
-              ref="v-expansion-panels"
               v-model="expand"
               class="mt-6 rounded facility-info"
               focusable
@@ -438,9 +437,6 @@ export default {
       const applicationList = Array.from(this.applicationMap?.values());
       return isAnyApplicationUnlocked(applicationList);
     },
-    numberOfPanelsToExpand() {
-      return this.$refs['v-expansion-panels']?.$children.length;
-    },
     isSummaryComplete() {
       if (this.hasChangeRequestType('MTFI') && this.summaryModel?.mtfiFacilities?.length === 0) return false;
       return this.invalidSummaryForms.length < 1;