Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update font-size to 16px #791

Closed
elliottSlee opened this issue Oct 20, 2022 · 3 comments
Closed

Update font-size to 16px #791

elliottSlee opened this issue Oct 20, 2022 · 3 comments
Labels
Task General activity not relate to a specific user story

Comments

@elliottSlee
Copy link
Contributor

elliottSlee commented Oct 20, 2022

User Story

As a designer
I want the default font size to 16px not 18px (100%, not 112.5%)
so that developed interfaces match my designs and are aesthetically pleasing and don't cause discord down the line regarding spacing and layouts.

Acceptance Criteria

Given that any user is on any page
when the root font-size of the browser is set to 16px (or default)
then any text that is not a heading will display at 16px

Description

This has implications for how the layouts are implemented. A great example is that the width of the analyst navigation sidebar (#760) is largely determined by the font-size. This affects the layout of it beside the page contents inside the container.

If the font-size stays at 112.5% (i.e., 18px) then the width of the widest button is 152px. That means the application view would would have to be 1010 with 8px in between sidebar and application. However, if a browser's root font size is set to something larger such as 18px, when they navigate to our site which resizes to 112.5% it'll turn into 20.25, which would make the button to 167, which would push into the page contents and possibly cause some users to have to scroll horizontally.

@elliottSlee elliottSlee changed the title Update font-size Update font-size to 16px Oct 20, 2022
@elliottSlee
Copy link
Contributor Author

@MarsRomer just bringing this card to your attention as it has implications for designs & layout

@matthieu-foucault
Copy link
Contributor

This can be solved by contributing to button-inc/service-development-toolkit#576

@eazeredo eazeredo added wontfix Task General activity not relate to a specific user story and removed wontfix labels Nov 3, 2022
@marcellmueller
Copy link
Contributor

Closing as this was completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Task General activity not relate to a specific user story
Projects
None yet
Development

No branches or pull requests

4 participants