Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow configuring how --ignore should be passed (or if it should be passed at all) #58

Open
dakrone opened this issue Nov 18, 2016 · 2 comments
Open

Allow configuring how --ignore should be passed (or if it should be passed at all) #58

dakrone opened this issue Nov 18, 2016 · 2 comments
Labels
help wanted

Comments

@dakrone
Copy link

dakrone commented Nov 18, 2016 •
edited
Loading

helm-projectile shouldn't hardcode how --ignore is passed.

See: emacsorphanage/helm-ag#283 for more information. I'd love to be able to customize a var that changes this to --ignore-file for ripgrep (or rather, not pass it at all since ripgrep uses your .gitignore correctly)
@xiongtx
Copy link
Collaborator

xiongtx commented Jan 28, 2017

@bbatsov Do we need to add projectile-ripgrep and corresponding helm-projectile-ripgrep commands, since we have projectile-ag, projectile-ack, etc.? Or try to provide a single command as an interface to many search tools like helm-ag tries to do?

Either way, @dakrone, a patch would be welcome.

@clayliddell clayliddell mentioned this issue Jun 26, 2020
Open
@arichiardi
Copy link

arichiardi commented Aug 30, 2024 •
edited
Loading

Oh - yes (7 years later) I have identified this one too - disallowing --ignore would also solve #21

arichiardi added a commit to arichiardi/helm-projectile that referenced this issue Aug 30, 2024
@arichiardi
Introduce helm-projectile-ignore-strategy, closes bbatsov#58
c6799a8 
New defcustom that when set to 'projectile', will compute ignores and
explicitely add additionally command line arguments to the search tool.
Note that this might override search tool specific behaviors (for
instance ag would not use VCS ignore files).
arichiardi added a commit to arichiardi/helm-projectile that referenced this issue Aug 30, 2024
@arichiardi
Introduce helm-projectile-ignore-strategy defcustom, closes bbatsov#58
89301dc 
New defcustom that when set to 'projectile', will compute ignores and
explicitely add additionally command line arguments to the search tool.
Note that this might override search tool specific behaviors (for
instance ag would not use VCS ignore files).
arichiardi added a commit to arichiardi/helm-projectile that referenced this issue Aug 30, 2024
@arichiardi
Introduce helm-projectile-ignore-strategy defcustom, closes bbatsov#58
199ec84 
New defcustom that when set to 'projectile', will compute ignores and
explicitely add additionally command line arguments to the search tool.
Note that this might override search tool specific behaviors (for
instance ag would not use VCS ignore files).
arichiardi added a commit to arichiardi/helm-projectile that referenced this issue Aug 30, 2024
@arichiardi
Introduce helm-projectile-ignore-strategy defcustom, closes bbatsov#58
7c39fc0 
New defcustom that when set to 'projectile', will compute ignores and
explicitely add additionally command line arguments to the search tool.
Note that this might override search tool specific behaviors (for
instance ag would not use VCS ignore files).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dakrone @xiongtx @arichiardi