Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External jar fetch from private S3 bucket #911

Closed
gmendonca opened this issue Jan 5, 2020 · 3 comments
Closed

External jar fetch from private S3 bucket #911

gmendonca opened this issue Jan 5, 2020 · 3 comments

Comments

@gmendonca
Copy link

I'm trying to use bazel-deps to resolve maven dependencies on AWS S3 with coursier(see bazeltools/bazel-deps#275 and coursier/coursier#1488). If this works out, there's still something that I think it needs to be done here, I might be wrong, so bear with me.

Since bazel-deps puts the jars under //external:jar/, I'm assuming scala_maven_import_external needs to be able to recognise and download s3:// jar paths when building the project with such dependencies.

@ittaiz
Copy link
Member

ittaiz commented Jan 5, 2020

scala_maven_import_external underneath uses repository_ctx.download. This recently got authentication support (1.2.1?).
I think these are the bits you need to get in place.
Don't know a lot more though.
Good luck.

@ittaiz
Copy link
Member

ittaiz commented Jan 15, 2020

@gmendonca can we close this?

@gmendonca
Copy link
Author

Yeah, sure. There's a FR on bazel already. Thanks!

gergelyfabian pushed a commit to gergelyfabian/rules_scala that referenced this issue May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants