-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warning about source-maps #44
Comments
There's a third option: remove the comment from the generated source file in the first place. Since the npm package doesn't (currently) ship with the source map, this probably makes sense independent of Bazel support. |
Even if you remove the source mapping line, you still need to do option 2 because we don't read the file to determine whether to enable source mapping. (I suppose we could, but we'd have to read all .js files that might be loaded during the program execution, which is all the action inputs in theory) |
Ah, okay. I'll do option 2 as well. |
GitHub had promised that their source archives would have stable checksums, but then there was a big Bazel outage yesterday due to their changing it. Even if they do make such a guarantee and stick to it, we also have the problem that GitHub doesn't give download metrics on their source archive so this is still worth changing.
A build at latest version reports
The
sass.dart.js
file in the npm:sass distro ends withbut no such file is in the distro.
We should either:
source-map-support
in thebuild_bazel_rules_sass_compiletime_deps
repo so that crashes of the sass tool will report Dart line numbers (probably useful for project maintainersinstall_source_map_support = False
in@io_bazel_rules_sass//sass:sass_bin
to suppress the warningThe text was updated successfully, but these errors were encountered: