Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with Rendering Versions #99

Open
oh-tarnished opened this issue Aug 28, 2023 · 1 comment
Open

Issue with Rendering Versions #99

oh-tarnished opened this issue Aug 28, 2023 · 1 comment

Comments

@oh-tarnished
Copy link

oh-tarnished commented Aug 28, 2023

Hey All,

Well I think the circle was probably not the right choice for displaying the versions that a bazel_dep depends on. This issue is for making a PR to fix that to maybe a curved rectangle.

Screenshot 2023-08-28 at 11 06 16 AM

also, can I revolve the building this project with bazel ? maybe using bzlmod

@hobofan
Copy link
Member

hobofan commented Nov 4, 2023

Sorry for not responding to this earlier!

Well I think the circle was probably not the right choice for displaying the versions that a bazel_dep depends on. This issue is for making a PR to fix that to maybe a curved rectangle.

Yeah, the more different versioning schemes appear in the BCR, the more obvious this becomes. I do already have a newer design for this in the works which I'll land a PR for in the next few days.

also, can I revolve the building this project with bazel ? maybe using bzlmod

I'd be open to have Bazel as a secondary build system in the project to make it easier to get going on the development of bcr-ui for people that are used to that.
However, since Bazel traditionally doesn't pair too well with Github Actions (like most systems with ephemeral runners), the main build will likely stay based on pnpm (without Bazel), so that we can maintain fast CI times.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants