Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Rating History/Scrimmaging Record Performance #826

Closed
acrantel opened this issue Sep 28, 2024 · 1 comment · Fixed by #846
Closed

Improve Rating History/Scrimmaging Record Performance #826

acrantel opened this issue Sep 28, 2024 · 1 comment · Fixed by #846
Assignees
@nour-massri
Labels
module: backend Related to the Siarnaq backend module priority: p2 medium
Milestone
Frontend2 Alpha

Comments

@acrantel
Copy link
Member

acrantel commented Sep 28, 2024 •
edited by lowtorola
Loading

Take a look at this pull request's code to find a more efficient way to compute rating history via querysets / subqueries
#558
@acrantel acrantel added triage New or unclassified issue module: backend Related to the Siarnaq backend module priority: p2 medium good first issue and removed triage New or unclassified issue labels Sep 28, 2024
@lowtorola lowtorola changed the title Improve Win Loss calculation performance Improve Rating History Performance Sep 28, 2024
@lowtorola lowtorola changed the title Improve Rating History Performance Improve Rating History/Scrimmaging Record Performance Oct 4, 2024
@lowtorola lowtorola mentioned this issue Oct 4, 2024
Merged
@lowtorola lowtorola added this to the Frontend2 Alpha milestone Oct 11, 2024
@lowtorola
Copy link
Contributor

For a bit of context on how bad my first pass implementation was, here's the current hook for getting the top 10 teams' rating histories:
image
We absolutely need a separate endpoint that does this all in a django query and returns the rating history for the top 10... then probably revert the API to only take a single team id for the regular case? We can discuss further

@nour-massri nour-massri linked a pull request Nov 4, 2024 that will close this issue
Nour/improving rating history performance #846
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nour-massri nour-massri

Labels
module: backend Related to the Siarnaq backend module priority: p2 medium
Projects
None yet
Milestone
Frontend2 Alpha
Development

Successfully merging a pull request may close this issue.

Nour/improving rating history performance battlecode/galaxy
3 participants
@acrantel @lowtorola @nour-massri