Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply low-hanging fruit fixes #1

Closed
hyperupcall opened this issue Oct 3, 2021 · 4 comments
Closed

Apply low-hanging fruit fixes #1

hyperupcall opened this issue Oct 3, 2021 · 4 comments
Assignees

Comments

@hyperupcall
Copy link
Member

hyperupcall commented Oct 3, 2021

This is a meta issue that tracks issues and PRs from repositories that were merged into this one that I likely plan to fix (at least initially). They include

Edit: Issues are now tracked in ./issues.md to prevent spamming references

@hyperupcall hyperupcall changed the title Library fixes Apply low-hanging fruit fixes Oct 3, 2021
@hyperupcall hyperupcall self-assigned this Oct 3, 2021
@jwheeler31
Copy link
Contributor

Submitted PR for bats-core/bats-assert#31

@hyperupcall
Copy link
Member Author

hyperupcall commented Oct 19, 2021

Submitted PR for bats-core/bats-assert#31

Thank you, I'll merge that in here soon :) (edit: done!)

I'll also add that I'm pretty sure there is no difference in behavior with the quotes in this case, due to the order Bash carries out various expansions (but correct me if I am wrong). The Bash man page says

Word splitting and pathname expansion are not performed on the words between the [[ and ]]; tilde expansion, parameter
and variable expansion, arithmetic expansion, command substitution, process substitution, and quote re‐
moval are performed. Conditional operators such as -f must be unquoted to be recognized as primaries.

And in both cases the right-hand-side is quoted so glob matching never occurs

@jwheeler31
Copy link
Contributor

Interesting. I can modify the existing PR to remove the quotes - I think it's become muscle-memory at this point.

@hyperupcall
Copy link
Member Author

You can add a commit if you want, but at least for me it's not really necessary since I already merged your changes in my fork, and this repository incorporates that revision :P

hyperupcall added a commit that referenced this issue Apr 11, 2022
e0eb8a2 Merge branch 'bats-core:master'
397c735 Fix markdown
7e4b104 Fix test badge
41e2804 Merge pull request #30 from nkakouros-forks/negative_index
9d89318 Merge pull request #41 from bats-core/martin-schulze-vireso-patch-1
a89786d Remove travis.yml
802d2a6 Merge branch 'bats-core:master' into master
d8124d7 Don't require package-log.json
d8d9711 Fix lock not found with setup-node
5497120 Add Github Action for running tests
4bdd58d Merge pull request #39 from stefanlasiewski/patch-1
eff064c docs: Avoid ambiguity in examples for assert/refute
522a65e Merge pull request #1 from bats-core/master
27f2e95 Fix: First two examples are backwards
34551b1 Merge pull request #37 from jwheeler31/master
a04c086 Added missing assertion.
c1276d1 Merge branch 'negative_index'
6ba332f Allows negative indexes in line assertions

git-subtree-dir: bats-assert
git-subtree-split: e0eb8a2c4b55fa0ee3b27c136186fc27dc597d4a
hyperupcall added a commit that referenced this issue Sep 30, 2023
99fc257 readme: Fix typos
fd0779b readme: Add deprecation notice
dd125c4 Merge branch 'master' of github.com:bats-core/bats-assert
9914beb Merge branch 'master' of github.com:bats-core/bats-assert
e0eb8a2 Merge branch 'bats-core:master'
802d2a6 Merge branch 'bats-core:master' into master
522a65e Merge pull request #1 from bats-core/master
c1276d1 Merge branch 'negative_index'
REVERT: 44913ff Merge pull request #58 from bats-core/workflow
REVERT: effe6f5 set bats_lib_path in test helper
REVERT: 1950e8c Replace inline tests workflow with reusable call
REVERT: 73a7cfa commit package-lock
REVERT: 2268cf9 Merge pull request #55 from Mukundan314/master
REVERT: 5da5830 Merge pull request #57 from bats-core/readme
REVERT: 0beceef Update README.md
REVERT: caafab6 readme tweaks
REVERT: 5b006b2 Remove dependency of package 'verbose'
REVERT: db015db Merge pull request #54 from bats-core/fix/issue-53-assert_regex-deems-regex-matching-empty-string-as-invalid
REVERT: 51f5fd7 assert_regex: matching empty string is not invalid regex

git-subtree-dir: bats-assert
git-subtree-split: 99fc25713adea7db5e37e3a7eb83b44ecc3ca53a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants