Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change how we use modals #367

Open
zavelevsky opened this issue May 24, 2022 · 1 comment · May be fixed by #560
Open

Change how we use modals #367

zavelevsky opened this issue May 24, 2022 · 1 comment · May be fixed by #560
Labels
PRIORITY Prioritized issues Technical Technical enhancement or debt

Comments

@zavelevsky
Copy link
Collaborator

We currently render modals as children of the components or buttons that will trigger them.
This is very limiting, as it doesn't allow a good way to manage the modals and to open another modal from within a modal.
Modals should be managed by a global service that abstracts them. Actions to open a modal will open a modal, same for closing.
If a modal is opened while another one is already displayed it will be rendered as a child modal - and clicking outside will close the latest modal.

case study: opening wallet connect modal from within the deposit modal.

Currently there's no good way to do it.
In the suggested way the modal at the root will display the deposit modal and will render a child modal - the wallet connect modal.

@pingustar
Copy link
Collaborator

comment from #349 from @ashachaf

after adding 3 different tokens to bancor network v3 pools, i was unable to scroll down to view the bottom of the screen on the portfolio page. (actually, even when navigating to other pages, i was unable to scroll down). after refresh, it was working again.

https://drive.google.com/file/d/10iTYWyJZs4jimBWPy_oA6RuHA7KtbkfP/view?usp=sharing

@RanCohenn RanCohenn self-assigned this Jul 12, 2022
@RanCohenn RanCohenn linked a pull request Jul 13, 2022 that will close this issue
@RanCohenn RanCohenn removed their assignment Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PRIORITY Prioritized issues Technical Technical enhancement or debt
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants