Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why do we use absolute instead of relative imports from fastlane_bot #477

Open
sklbancor opened this issue Mar 22, 2024 · 0 comments
Open

Comments

@sklbancor
Copy link
Collaborator

          Why do we use absolute instead of relative imports from fastlane_bot

not a point related specifically to this commit -- but why do we import from fastlane_bot using absolute rather than relative imports. Reasons to use relative imports

  1. that's what relative imports are for
  2. allows you to rename fastlane_bot module without changing 1000 lines of code
  3. somewhat clearer what is internal vs external to the library
  4. possibly very nasty and hard to detect errors*

*if there are multiple installations of fastlane_bot on the same system then I think there may be situations where from fastlane_bot refers to a different installation of the bot in which case you are probably truly f'd...

Originally posted by @sklbancor in #399 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant