From ab5af7d96be8e139233a903a3a149e1de1ab3359 Mon Sep 17 00:00:00 2001
From: Ivan Zhelyazkov <ivan.y.zhelyazkov@gmail.com>
Date: Wed, 12 Jun 2024 18:08:27 +0300
Subject: [PATCH] update default trading fee

---
 contracts/carbon/Strategies.sol   | 2 +-
 test/forge/CarbonController.t.sol | 4 ++--
 test/forge/Strategies.t.sol       | 4 ++--
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/contracts/carbon/Strategies.sol b/contracts/carbon/Strategies.sol
index 8d1e1f28..cd85fcf9 100644
--- a/contracts/carbon/Strategies.sol
+++ b/contracts/carbon/Strategies.sol
@@ -161,7 +161,7 @@ abstract contract Strategies is Initializable {
 
     uint256 private constant ORDERS_INVERTED_FLAG = 1 << 255;
 
-    uint32 private constant DEFAULT_TRADING_FEE_PPM = 2000; // 0.2%
+    uint32 private constant DEFAULT_TRADING_FEE_PPM = 4000; // 0.4%
 
     // total number of strategies
     uint128 private _strategyCounter;
diff --git a/test/forge/CarbonController.t.sol b/test/forge/CarbonController.t.sol
index 42efb419..fff70ad9 100644
--- a/test/forge/CarbonController.t.sol
+++ b/test/forge/CarbonController.t.sol
@@ -18,7 +18,7 @@ contract CarbonControllerTest is TestFixture {
     using Address for address payable;
 
     uint16 private constant CONTROLLER_TYPE = 1;
-    uint32 private constant TRADING_FEE_PPM = 2000;
+    uint32 private constant TRADING_FEE_PPM = 4000;
 
     /// @dev function to set up state before tests
     function setUp() public virtual {
@@ -32,7 +32,7 @@ contract CarbonControllerTest is TestFixture {
      * @dev construction tests
      */
 
-    function testShouldBeInitializedProperly() public {
+    function testShouldBeInitializedProperly() public view {
         uint256 version = carbonController.version();
         assertEq(version, 2);
 
diff --git a/test/forge/Strategies.t.sol b/test/forge/Strategies.t.sol
index edd17df2..dbbc233d 100644
--- a/test/forge/Strategies.t.sol
+++ b/test/forge/Strategies.t.sol
@@ -31,7 +31,7 @@ contract StrategiesTest is TestFixture {
     uint8 private constant STRATEGY_UPDATE_REASON_EDIT = 0;
     uint8 private constant STRATEGY_UPDATE_REASON_TRADE = 1;
 
-    uint32 private constant DEFAULT_TRADING_FEE_PPM = 2000;
+    uint32 private constant DEFAULT_TRADING_FEE_PPM = 4000;
     uint32 private constant NEW_TRADING_FEE_PPM = 300_000;
 
     uint256 private constant FETCH_AMOUNT = 5;
@@ -1266,7 +1266,7 @@ contract StrategiesTest is TestFixture {
         carbonController.pairTradingFeePPM(token0, token1);
     }
 
-    function testSetsTheDefaultOnInitialization() public {
+    function testSetsTheDefaultOnInitialization() public view {
         uint32 tradingFee = carbonController.tradingFeePPM();
         assertEq(tradingFee, DEFAULT_TRADING_FEE_PPM);
     }