Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overlapping graph with extreme values #989

Merged
merged 8 commits into from
Jan 18, 2024
Merged

Overlapping graph with extreme values #989

merged 8 commits into from
Jan 18, 2024

Conversation

GrandSchtroumpf
Copy link
Collaborator

@GrandSchtroumpf GrandSchtroumpf commented Jan 16, 2024

fix #987
fix #972

  • Initialize min & max differently if market price is below 1wei
  • Change graph ratio to support large difference between price range and between market price & price.
  • Ensure price initialization in production mode

Copy link

cloudflare-workers-and-pages bot commented Jan 16, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0d638f1
Status: ✅  Deploy successful!
Preview URL: https://7bc474ef.carbon-app-csq.pages.dev
Branch Preview URL: https://issue--987.carbon-app-csq.pages.dev

View logs

Copy link
Collaborator

@pingustar pingustar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Left some nit comments

@ashachaf
Copy link
Collaborator

@GrandSchtroumpf GrandSchtroumpf merged commit 6a6272d into main Jan 18, 2024
1 check passed
@GrandSchtroumpf GrandSchtroumpf deleted the issue-#987 branch January 18, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants