Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add undercut option to duplicate strategy flow #702

Closed
Costa769 opened this issue Jul 3, 2023 · 1 comment · Fixed by #878
Closed

Add undercut option to duplicate strategy flow #702

Costa769 opened this issue Jul 3, 2023 · 1 comment · Fixed by #878
Assignees
Milestone

Comments

@Costa769
Copy link
Collaborator

Costa769 commented Jul 3, 2023

Summary

When a user duplicates a strategy, we want to provide them with an option to undercut the original strategy's prices, allowing their newly duplicated strategy to be fulfilled ahead of the original one.

Designs

Duplicate modal with two options

Flow

When the user clicks on the duplicate strategy icon, we want to show a modal with two options.

  1. Duplicate as is
  2. Undercut the strategy

IF "Duplicate as is" is selected (same behavior as the current duplicate strategy icon on click).

  • Navigate to the set prices page with the strategy tokens and type preselected, and prices and budgets prefilled with the values of the original strategy.

IF "Undercut the strategy" is selected

  • Navigate to the set prices page with the strategy tokens and type preselected, and budgets prefilled with the values of the original strategy.
  • Undercut the prices by 0.1%.
  • Formula:
    -- {Undercut token buy price} = {Original token buy price}+ {Original token buy price} * 0.1/100
    -- {Undercut token sell price} = {Original token sell price}- {Original token sell price} * 0.1/100
  • Examples:
    -- User duplicates a ETH/USDC strategy with range buy ETH for min 1600 USDC- max 1700 USDC and limit sell ETH for
    1800 USDC prices
    -- Undercut token min buy price = 1600+1600 * 0.1/100= 1601.6
    -- Undercut token max buy price = 1700+1700 * 0.1/100= 1701.7
    -- Undercut token sell price = 1800-1800 * 0.1/100= 1798.2
@Costa769 Costa769 added this to the RC1 milestone Jul 3, 2023
@Costa769 Costa769 self-assigned this Jul 3, 2023
@Costa769 Costa769 removed their assignment Jul 26, 2023
tiagofilipenunes added a commit that referenced this issue Oct 20, 2023
tiagofilipenunes added a commit that referenced this issue Oct 20, 2023
@tiagofilipenunes tiagofilipenunes linked a pull request Nov 6, 2023 that will close this issue
8 tasks
@zavelevsky
Copy link
Collaborator

@ashachaf @Costa769 do we want different analytics events depending on the option the user selected?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants