Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor githubAuthButton as a reactive widget #12

Open
micahjsmith opened this issue Jul 2, 2021 · 0 comments
Open

Refactor githubAuthButton as a reactive widget #12

micahjsmith opened this issue Jul 2, 2021 · 0 comments

Comments

@micahjsmith
Copy link
Contributor

Currently githubAuthButton is a ToolbarButton. Then we call the authCallback function at an interval to determine if the user has successfully authenticated, and if so, to change the button visually to indicate success (i.e. background color to green). I'm sure it would be better to implement this as a ReactWidget where the button itself is responsible for determining the authentication status and changing its own appearance accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant