You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
the input to the pull request creation method is the code content, which is an arbitrary string
you could parse the code with static analysis to try to recover the feature attributes like the name, but not guaranteed to succeed, for example someone could submit a code cell which does not include a feature definition
if you use dynamic analysis, i.e. eval the code and try to import the feature, it could have side effects (and be a security vulnerability), though of course a user who did this would just be hurting their own development environment
after one of the above attempts, a fallback in case any errors occur could just be the existing PR message
can supplement this automatic detection with user confirmation
existing flow: select code cell(s) -> press submit -> confirm the code content is as desired -> feature is submitted
candidate flow: select code cell(s) -> press submit -> confirm the code content is as desired -> confirm the automatically detected metadata is as desired, and if not, option to correct it -> feature is submitted
yes this would definitely be possible, the relevant method is here: https://github.com/ballet/ballet-assemble/blob/master/server/ballet_assemble/app.py#L229
considerations
select code cell(s) -> press submit -> confirm the code content is as desired -> feature is submitted
select code cell(s) -> press submit -> confirm the code content is as desired -> confirm the automatically detected metadata is as desired, and if not, option to correct it -> feature is submitted
h/t @dyuliu
The text was updated successfully, but these errors were encountered: