Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add animation showing steps taken when feature is submitted #1

Open
micahjsmith opened this issue Aug 3, 2020 · 1 comment
Open

Comments

@micahjsmith
Copy link
Contributor

micahjsmith commented Aug 3, 2020

Current behavior

  • users confirms they want to submit feature
  • AssembleApp running on jupyter server goes through steps to submit feature: (1) extract code from payload, (2) fork upstream repo if applicable (3) clone to tmp (4) render feature module (5) copy code to feature module (6) commit files (7) push to origin (8) pull request to upstream
  • after failure or success, a new modal shows result to user

Desired behavior

  • user confirms they want to submit feature
  • UI immediately shows some sort of "processing" animation, ideally showing the actual steps the server is taking
  • after failure or success, the processing animation is replaced by the result modal
@pecirep
Copy link
Collaborator

pecirep commented Jul 21, 2021

I would like to approach implementing this behavior in two separate stages:

  1. show a simple spinner while the feature is being submitted, just to communicate to the user that something is happening
    • this can be achieved my showing a modal immediately after the user confirms the feature in the dialog, instead of waiting for the api call
  2. show detailed steps instead of a spinner:
    • when a feature is submitted to the extension backend, the state of the feature submission is kept track of in a global variable (or more specifically in a dictionary, to keep track of multiple submissions concurrently)
    • the feature submission endpoint returns a random uuid that can be used by the frontend to make repeated (~500ms) calls to the backend in order to fetch the state of the submission as it updates and update the animation accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants