Weather image not displaying on the Waveshare display

[ArsamS]

18.05.21 00:00:17 (+0800) inkyshot INFO:root:Retrieving weather forecast
18.05.21 00:00:20 (+0800) inkyshot INFO:root:Prepare the weather data for drawing
18.05.21 00:00:20 (+0800) inkyshot INFO:root:Creating a transparency mask for the image
18.05.21 00:00:24 (+0800) inkyshot INFO:root:Done drawing

While the text is displayed, there is no symbol on the right hand side

[louispires]

Also experiencing this same issue.

[gelbal]

Thanks for reporting it. It works fine on InkyPHAT so I didn't notice this. I don't have a Waveshare display myself to debug this. Do you have one @chrisys @catt-tung to help out with debugging?

[louispires]

I managed to debug and get it sort of working.

Seems like the problem is with the icon_mask

I removed the mask from the img.paste(icon_image, (120, 3)) line and now I am getting an Image, not exactly correct:

[chrisys]

Thanks to @louispires for the PRs addressing this but it's still not perfect. Having looked at it a little the root cause is probably the difference in image handling between the Inky and EPD libraries. The weather PNGs sometimes have a single colour, for example white on a transparent background, but sometimes have black on transparent, sometimes red white and black on transparent. This is what's causing some images to appear blank, because the white pixels are being treated as something not to display by EPD and the opposite (correctly) by Inky, so if we invert that the problem just swaps to the other display and still isn't resolved. I don't have spare time to look into this any more but feel free to keep making PRs and I'll test them when I can!