New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make unit: and index: standard across docs and examples #6

Open

maggie44 opened this issue Oct 21, 2022 · 0 comments

Contributor

maggie44 commented Oct 21, 2022

The examples read (https://github.com/balena-labs-research/balenaVirt/blob/master/examples/guests.aarch64.yml):

      - if: virtio
        format: qcow2
        unit: 0
        file: /data/{{templateName}}{{guestId}}.qcow2

The docs read:

drive:
  - if: virtio
    format: qcow2
    file: /data/guest{{guestId}}.qcow2
    index: 0
    media: disk

Caused a bit of a pause while working out whether index: or unit: were necessary. We could standardise the docs and examples to use the same.

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment