Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add child gauges v2 to labels #43

Closed
mendesfabio opened this issue Nov 28, 2023 · 6 comments
Closed

add child gauges v2 to labels #43

mendesfabio opened this issue Nov 28, 2023 · 6 comments
Assignees

Comments

@mendesfabio
Copy link
Member

No description provided.

@mendesfabio
Copy link
Member Author

From Troy:

WIP:

https://dune.com/queries/3094729

  1. I got all root gauges that had received a vote and then joined a table of all the decoded root gauge contracts we have on Dune;
  2. Created mapping queries for each type of L2 gauge and joined them on the aforementioned table.

* IIRC these queries are just for the v2 gauges, as I do not recall getting the streamers.

Notes:

  • On Optimsim the child chain gauge contract is under balancer_v2 namespace and not balancer. The factory is under balancer namespace. I have updated the queries to use balancer_v2 but ideally it is under balancer. I tried to change it to balancer but it got rejected.
  • There some empty polygonZKEVM entries because we have no contract data, obviously. Not a blocker but just noting here.
  • There are 9 mainnet gauges from very early on that I was going to wait until the end to resolve.
  • I think the main remaining portion is adding the logic for v1 gauges (streamer etc). I believe this is what the remaining missing pool address mappings can be attributed too.
  • The namespace and contract naming was a big time sink. There are some instances of 2 different root gauges being mapped to the same recipient search for 0x8fb44263b91cac11a646cee0d44c6600cb4d5ed9 in this query .
  • Ideally, all of the gauge related contracts are moved to balancer namespace, removed from balancer v2 (can't be removed if used in a spell so have to change the spell to the new contract namespace first per Antonio), and have uniform naming conventions across the various contracts.

@viniabussafi viniabussafi self-assigned this Dec 21, 2023
@viniabussafi
Copy link
Member

viniabussafi commented Dec 22, 2023

Query ran for Arbitrum.
To do: create spell for avalanche, base and gnosis and run PR.

@viniabussafi
Copy link
Member

viniabussafi commented Dec 22, 2023

PR created and tested. Waiting for review.

@viniabussafi
Copy link
Member

Just for context, the logic is:
output_0 balancer_ethereum.CappedArbitrumRootGaugeFactory_call_create recipient --> output_0 balancer_arbitrum.ChildChainGaugeFactory_call_create pool -->
address labels.balancer_v2_pools_arbitrum

@viniabussafi
Copy link
Member

PR approved. Will close the issue once it's merged and tested

@viniabussafi
Copy link
Member

Child gauges added. The only missing labels are for pools with no labels, which we will have to investigate.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants