Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor deployment/test helpers #2088

Closed
EndymionJkb opened this issue Dec 1, 2022 · 0 comments · Fixed by #2099
Closed

Refactor deployment/test helpers #2088

EndymionJkb opened this issue Dec 1, 2022 · 0 comments · Fixed by #2099
Assignees

Comments

@EndymionJkb
Copy link
Collaborator

As noted in the description of #2078 , the test helpers - WeightedPoolDeployer in particular - have, with the proliferation of pool types, grown into "unholy abominations" that are doing too much. We have moved the solidity codebase from generic base contract with lots of special casing toward encapsulating pool-specific functionality within each contract, and could do much the same here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant