Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulnerable Node.js Dependencies #167

Closed
EricR opened this issue Nov 20, 2019 · 1 comment
Closed

Vulnerable Node.js Dependencies #167

EricR opened this issue Nov 20, 2019 · 1 comment

Comments

@EricR
Copy link

EricR commented Nov 20, 2019

Description

The following two Node.js dependencies are outdated contain known vulnerabilities:

Because these dependencies are only used within a developer environment, this issue is considered informational.

Recommendation

Short term, upgrade the handlebars library to the latest version. In addition, consider using an alternative to web3 until a patch is made available.

Long term, integrate tools such as npm audit and yarn audit into Balancer's CI pipeline so that vulnerabilities can be caught before code changes are pushed.

@mikemcdonald
Copy link
Member

handlebars is a dependency of solidity-coverage -> istanbul which doesn't look like will be updated gotwarlost/istanbul#920

Since this is only for running tests in a dev environment, will mark as won't fix.

I will add yarn audit to the pipelines for any of the frontend dapps: balancer-exchange and balancer-dapp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants