Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

%first should not be lower case #71

Closed
rummik opened this issue Oct 16, 2013 · 6 comments
Closed

%first should not be lower case #71

rummik opened this issue Oct 16, 2013 · 6 comments
Milestone

Comments

@rummik
Copy link
Contributor

rummik commented Oct 16, 2013

http://img.shields.io/Freenode/Test.png -- 'Freenode' should be uppercase in the image, but it's lowercase

@chadwhitacre
Copy link
Contributor

This might be a stylistic decision. @olivierlacan?

@olivierlacan
Copy link
Member

Whoa, that's actually an interesting one. I would tend to agree. If we're respecting the case on one side (value) why wouldn't we respect it on the other (key)?

@nathany
Copy link
Contributor

nathany commented Jan 9, 2014

GPA is uppercase in the examples on the README. Implementation-specific issue?

One could argue that consistent application of lower case is better (on both sides). How would these look as images?

build | status CODE CLIMATE | 2.3 gEmFuRy | 1.2.3

@espadrine
Copy link
Member

I'd rather we kept the input string as God the user intended. It is sacred to me.

@nathany
Copy link
Contributor

nathany commented Jan 9, 2014

:-) Let's include this in the API documentation #100

@chadwhitacre
Copy link
Contributor

Fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants