-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does not work on node 17 or above, requires node 16 #39
Comments
No, it just means that 16 was most recent at the time of writing. Is there something not working on 17+? |
Oh okay, 17&18 was out at that time so I assumed. Just doesn't start for me on 16+ and there are other reports on google. https://stackoverflow.com/questions/70278340/unable-to-run-karmajsdom-tests-on-nodejs-17-x
Also what do you think about converting this to happy-dom instead? @badeball from what I see then callback never happens.
|
This might be of interest to you. Can you try running tests with
I think a happy-dom integration should exist as a separate package. |
That does fix it, are you able to use 16+ without that option? |
It's a bit up to you. You can either run your app and have it listen on both ipv4 and ipv6, in which case all node versions are going to work or you have to tell node and jsdom what you mean when you ask it to access "localhost". You can change the default from the runtime like so: import dns from "node:dns";
dns.setDefaultResultOrder("ipv4first"); |
Wait, karma is the app in this context (I forget what repo I am in..). Maybe we can make some assumptions about it. Leaving this open for now. |
I don't understand, where do I do this? Shouldn't it be handled by the launcher? Other launchers like ChromeCanaryHeadless that I'm also using works fine without any changes. |
Seems like this is known? f78b1b5
Is there any plan to fix this or is it just stuck on 16 forever?
The text was updated successfully, but these errors were encountered: