scan_regex too restrictive?

[kaihowl]

New Issue Checklist

• Using the latest version of azohra/shell-linter
• Able to reproduce error multiple times
• Provided information about the bug
• Attached additional information about the error including logs

Issue Description

The `scan-regex` with `#!.*[/ ](sh|bash|dash|ksh)$` does not expect valid options in shebang.

Steps to Reproduce

Add a repo with a bash file "test.sh" that start with `#!/bin/bash -e`.

Error Message

ShellCheck only supports sh/bash/dash/ksh scripts. For supported scripts to be scanned, make sure to add a proper shebang on the first line of the script.

Logs

n/a

Link to the GitHub Actions workflow (optional)

n/a

[kaihowl]

Hi,

shellcheck also supports forcing zsh scripts for example to be interpreted as if they are bash script by adding the following after the shebang:

# shellcheck shell=bash

Is that also something that should be supported? Or is it already and I overlooked something in the configuration?

[ThomDietrich]

This is an old issue but still relevant. Your project is currently not compliant with: https://www.shellcheck.net/wiki/SC1008

The regex in question is

shell-linter/entrypoint.sh

Line 12 in 82f6fac

scan_regex="#!.*[/ ](sh|bash|dash|ksh)$"

Therefore, # shellcheck shell=bash is not supported.

I would suggest to extend the head command to include the second line and support = in the regex.

shell-linter/entrypoint.sh

Line 78 in 82f6fac

local first_line=$(head -n 1 "$script")

Would the maintainers accept a PR for this?