-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n support #6
Comments
Thanks @jclusso! I haven't done much i18n in Bridgetown which is why I've never run into this limitation before. The plugin absolutely should support it. I'll keep an eye on the upstream PR into Bridgetown and try to find some time for this in the next few weeks. If you wanted to contribute a PR for this though, I'll happily merge it in :). |
@ayushn21 I realized after I submitted this that we aren't even using this gem at the moment because it was too slow for our build. We use the one built into Netlify that is much faster. This however might be faster once it ignores all the other locales so. |
Ah fair enough ... If it was too slow I'm curious to understand the bottleneck and where I can make any optimisations. If you're able to share some details, that'd be super useful! :) |
@ayushn21 for context our site takes 587ms on Netlify to build the sitemap, but with this gem it takes roughly 94 seconds. Our build takes 34s without the gem and 128s with it. |
Wow that's insane .... if you're able to share some more specific info about the cause of the performance issues, please do! That kind of performance bottleneck is definitely a bug. |
@ayushn21 I'm not really sure, my only guess is it's related to the fact we have 8 locales and a bunch of generated pages. |
I realized this plugin is missing some key functionality to support Bridgetown fully. To support i18n, the simplest thing to do would be to ignore all locaes, but the main one. Users can then specify hreflang tags on their site as I've proposed as well bridgetownrb/bridgetown#930.
The text was updated successfully, but these errors were encountered: