Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible algorithms for checking the BackoffRate value in statelint and VSCode AWS toolkit plugin #45

Open
ghost opened this issue Jan 26, 2021 · 3 comments

Comments

@ghost
Copy link

ghost commented Jan 26, 2021

For statelint 1 is an invalid BackoffRate value (must be 1.0), but for VSCode AWS toolkit plugin 1 is OK:

image

@timbray
Copy link
Contributor

timbray commented Jan 26, 2021

The thing to do is to see what the actual service accepts (don't know off the top of my head) and make it consistent with that.

@wong-a
Copy link
Collaborator

wong-a commented Jan 26, 2021

The service accepts both "BackOffRate": 1.0 and "BackOffRate": 1.

The spec only requires that the value be a number:

a field named "BackoffRate", a number which is the multiplier that increases the retry interval on each attempt (default: 2.0). The value of BackoffRate MUST be greater than or equal to 1.0.

@timbray
Copy link
Contributor

timbray commented Jan 26, 2021

The service accepts both "BackOffRate": 1.0 and "BackOffRate": 1.

The spec only requires that the value be a number:

a field named "BackoffRate", a number which is the multiplier that increases the retry interval on each attempt (default: 2.0). The value of BackoffRate MUST be greater than or equal to 1.0.

OK, so statelint is wrong, the .j2119 says it has to be a float. Easy fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants