Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support chunking with batchGet in getter.js #1209

Open
wants to merge 1 commit into
base: mainline
Choose a base branch
from

Conversation

AaronJackson
Copy link

@AaronJackson AaronJackson commented Jul 18, 2023

Fixes #1180

If a user is in more than 100 studies as an admin or a user, the Studies page will fail to load for that user, giving a validation error from DynamoDB BatchGetItem in the returned JSON. From what I understand, the first query which finds which studies a user has access to, succeeds. Only the fetch of the details for these studies fails.

Description of changes:

This enables chunking of DynamoDB BatchGet requests if there are more than 100 results. I'm not sure if this is the most appropriate solution as I think a Scan should be used, but it was a quick fix for our SWB deployment.

Checklist:

  • Have you successfully deployed to an AWS account with your changes?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully tested with your changes locally?
  • If new dependencies have been added, have they been pinned to specific versions?
  • Is this change also required on the AWS Solution version?
  • Have you updated openapi.yaml if you made updates to API definition (including add, delete or update parameter and request data schema)?
  • If you had to run manual tests, have you considered automating those tests by adding them to end-to-end tests?
  • If you are updating the changelog and vending out a new release, have you updated versionNumber and versionDate in .defaults.yml

AS review ticket id:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@maghirardelli
Copy link
Contributor

Thank you for reaching out. Your request has been added to our backlog for research computing solutions. Our
team curates these requests for fit with our solutions vision on a regular basis. Please watch this space for new
updates. If you require immediate assistance, please reach out to your AWS account team. Please note that
security issues should be reported directly to AWS Security at [email protected].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] A user cannot be in more than 100 studies at a time
2 participants