Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Bucket Policy Limitations #1126

Open
joelmacey opened this issue Feb 13, 2023 · 3 comments
Open

[Bug] Bucket Policy Limitations #1126

joelmacey opened this issue Feb 13, 2023 · 3 comments
Labels
bug Something isn't working closing-soon-if-no-response Ask for response from requester, will close issue in 7 days if no response Review One Review Two

Comments

@joelmacey
Copy link

Describe the bug
When a large amount of users or organisation groups use the same study data bucket, the bucket policy exceeds the 20KB limit, as SWB amends the existing bucket policy and adds 3 new entries allowing Get, Put and List access to the user/organisation.
This leads to users not being able to access their uploaded study data when using their workspace.

To Reproduce
Steps to reproduce the behavior:

  1. Create multiple users
  2. Create a new study
  3. Launch new workspace
  4. Repeat until bucket policy is > 20KB
  5. When you launch the next workspace, the study data will not be available.

Expected behavior
Bucket policy should not exceed the 20KB limit and users should be able to access their study data.

Screenshots
Example bucket policy
image

Versions :

  • Version 5.2.7
  • Modified version of SWB, with custom workspaces, styling, etc - but wouldn't affect bucket policies.
@joelmacey joelmacey added the bug Something isn't working label Feb 13, 2023
@SanketD92
Copy link
Contributor

Hello @joelmacey, we're aware of this particular scaling limitation and it has been added to our backlog.

Thank you for opening this issue and your interest in Service Workbench.

@tdmalone
Copy link
Contributor

@joelmacey We worked around this issue by modifying SWB to not adjust the bucket policy at all. This was safe in our case because the administrators with access to the main account are the same as those with access to the hosting accounts, and the bucket access is also controlled on the role added to the launched instances.

In other words, access was being controlled in two places, one that scales (instance roles, in hosting account) and one that doesn't (bucket policy, in main account).

@kpark277 kpark277 added the closing-soon-if-no-response Ask for response from requester, will close issue in 7 days if no response label Apr 3, 2023
@tdmalone
Copy link
Contributor

tdmalone commented Apr 4, 2023

Adding response so this doesn't get closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working closing-soon-if-no-response Ask for response from requester, will close issue in 7 days if no response Review One Review Two
Projects
None yet
Development

No branches or pull requests

6 participants