Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPU/CPU Temp #2

Open
cpdlink opened this issue Mar 6, 2021 · 7 comments
Open

GPU/CPU Temp #2

cpdlink opened this issue Mar 6, 2021 · 7 comments

Comments

@cpdlink
Copy link

cpdlink commented Mar 6, 2021

Raspberry Pi 4B running Raspberry Pi OS Lite (Release date: January 11th 2021, Kernel version: 5.4):

  1. both GPU & CPU Temp labels have wrong background color when using MC color scheme - black instead of blue probably applies to all other non default color schemes; version 2.0.2 had the correct background value (please see attached sample)
  2. wrong/inconsistent spelling of GPU & CPU Temp labels: i.e. Cpu & Gpu (mixed caption) instead of CPU & GPU (all CAPS) as everywhere else (please see attached sample)
  3. GPU Temp shows zero degrees although CLI command shows correct value when queried "vcgencmd measure_temp"
  4. degree symbol missing from both GPU and CPU Temp meters C instead of °C (please see attached sample)
  5. it would be a lot more readable if you could right-align the colon character of all text meters (please see attached sample)
  6. <Time> meter not available anymore - it use to be part of the version 2.0.2
    htop_issues

thank you!

@avafinger
Copy link
Owner

Interesting findings.

| 3. GPU Temp shows zero degrees although CLI command shows correct value when queried "vcgencmd measure_temp"
This is similar to avafinger/htop_2.2.2-amd64#2

There will be a security breach if htop can run a script or program to find some platform specific information. I was thinking of overcoming this by passing a parameter when executing htop, so that it would be up to the user to decide on the security risks.

Another challenge is that the headers are generated automatically, with this design it is impossible to build with gcc 10.
The alignment looks very good, but it will certainly create problems if you have a screen size of 80x24, some information may be cut off.

Anyway, I will review the code and try to fix it.

@avafinger
Copy link
Owner

6. <Time> meter not available anymore - it use to be part of the version 2.0.2

To show the Time use the Clock meter.

@avafinger
Copy link
Owner

Can try to build from the source and check if it works for you?

https://github.com/avafinger/htop_2.2.2/commits/master

@cpdlink
Copy link
Author

cpdlink commented Mar 17, 2021 via email

@roy-m-organ
Copy link

New to Github, this is a necessary add

@avafinger
Copy link
Owner

@roy-m-organ
Copy link

roy-m-organ commented May 23, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants