Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing openzeppelin-contracts dependency #448

Closed
cam-schultz opened this issue Jul 25, 2024 · 1 comment
Closed

Consider removing openzeppelin-contracts dependency #448

cam-schultz opened this issue Jul 25, 2024 · 1 comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request

Comments

@cam-schultz
Copy link
Contributor

Context and scope
With #397, we added support for upgradeable variants of Teleporter utilities to allow for Teleporter apps to be implemented in an upgradeable fashion. In doing so, we added an additional submodule dependency for openzeppelin-contracts-upgradeable in addition to the existing openzeppelin-contracts submodule.

openzeppelin-contracts-upgradeable itself includes openzeppelin-contracts as a submodule, so our openzeppelin-contracts submodule is likely redundant.

Discussion and alternatives
This may help reduce the chance of import conflicts, which can cause headaches in CI.

Open questions
We currently don't enforce similar versions for openzeppelin-contracts and openzeppelin-contracts-upgradeable. Are we comfortable using the openzeppelin-contracts version specified in openzeppelin-contracts-upgradeable?

@cam-schultz cam-schultz added enhancement New feature or request dependencies Pull requests that update a dependency file labels Jul 25, 2024
@geoff-vball
Copy link
Contributor

Completed

@github-project-automation github-project-automation bot moved this from Backlog 🗄️ to Done ✅ in Platform Engineering Group Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

2 participants