Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable comment linting #1327

Closed
wants to merge 1 commit into from
Closed

Enable comment linting #1327

wants to merge 1 commit into from

Conversation

ecordell
Copy link
Contributor

@ecordell ecordell commented May 18, 2023 •
edited
Loading

Will take some time to pass all of the tests

@github-actions github-actions bot added the area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) label May 18, 2023
@ecordell ecordell mentioned this pull request May 18, 2023
Merged
@github-actions github-actions bot added area/api http Affects the HTTP Gateway API area/api v0 Affects the v0 API area/api v1 Affects the v1 API area/CLI Affects the command line area/dashboard Affects the dashboard area/datastore Affects the storage system area/dispatch Affects dispatching of requests area/schema Affects the Schema Language labels May 18, 2023
vroldanbet
vroldanbet reviewed May 18, 2023
View reviewed changes
Copy link
Contributor

@vroldanbet vroldanbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fear having this linter around is going to cause friction on the dev experience. We already have gofumpt for the pain 😅 Perhaps we could merge the changes but leave the linter disabled?

@github-actions github-actions bot removed area/dashboard Affects the dashboard area/api v0 Affects the v0 API area/api v1 Affects the v1 API area/dispatch Affects dispatching of requests area/datastore Affects the storage system area/schema Affects the Schema Language area/api http Affects the HTTP Gateway API labels May 18, 2023
@ecordell ecordell changed the title whitespace and comment linting Enable comment linting May 22, 2023
@josephschorr
Copy link
Member

Closing; we can reopen if necessary down the road

@github-actions github-actions bot locked and limited conversation to collaborators Nov 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vroldanbet vroldanbet vroldanbet left review comments

Assignees
No one assigned
Labels
area/CLI Affects the command line area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ecordell @josephschorr @vroldanbet