Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be able to retry on errors other than Auth0::RateLimitEncountered? #500

Open
5 tasks done
yk-ms opened this issue Jul 19, 2023 · 1 comment
Open
5 tasks done

Be able to retry on errors other than Auth0::RateLimitEncountered? #500

yk-ms opened this issue Jul 19, 2023 · 1 comment
Labels
feature request A feature has been asked for or suggested by the community

Comments

@yk-ms
Copy link

yk-ms commented Jul 19, 2023

Checklist

  • I have looked into the Readme and Examples, and have not found a suitable solution or answer.
  • I have looked into the API documentation and have not found a suitable solution or answer.
  • I have searched the issues and have not found a suitable solution or answer.
  • I have searched the Auth0 Community forums and have not found a suitable solution or answer.
  • I agree to the terms within the Auth0 Code of Conduct.

Describe the problem you'd like to have solved

I want to optionally control whether or not retries are performed when RestClient::RequestTimeout occurs instead of Auth0::RateLimitEncountered.

Describe the ideal solution

As a condition of retry, option to be executed in another error class.

Alternatives and current workarounds

No response

Additional context

No response

@yk-ms yk-ms added the feature request A feature has been asked for or suggested by the community label Jul 19, 2023
@yk-ms yk-ms changed the title Be able to retry on errors other than Auth0::RateLimitEncountered. Be able to retry on errors other than Auth0::RateLimitEncountered? Jul 19, 2023
@stevehobbsdev
Copy link
Contributor

stevehobbsdev commented Aug 14, 2023

Thanks for your patience here @yk-ms - can you tell us more about your use case?

This is configured by Retryable, and looks like they support global defaults but I suspect this will not work for you as we override them.

We could put some configuration in to pass through to Retryable. Happy to accept a PR to look into, but otherwise it's very low priority for us at the moment. In the meantime, you should be able to handle this exception yourself and retry the request appropriately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request A feature has been asked for or suggested by the community
Projects
None yet
Development

No branches or pull requests

2 participants