Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Dataset.repository_link on all backends #11

Open
hagenw opened this issue Apr 5, 2023 · 0 comments
Open

Support Dataset.repository_link on all backends #11

hagenw opened this issue Apr 5, 2023 · 0 comments

Comments

@hagenw
Copy link
Member

hagenw commented Apr 5, 2023

This is the second part of #4.

At the moment audbcards.Dataset.repository_link simply expects an Artifactory backend, e.g.

NOTE: the following code needs to executed using the add-test-db-fixture branch at the moment.

>>> import audbcards
>>> dataset = audbcards.Dataset('emodb', '1.3.0')
>>> dataset.repository_link
'`data-public <https://audeering.jfrog.io/artifactory/webapp/#/artifacts/browse/tree/General/data-public/emodb>`__'

One solution to make this independent of the used backend would be by introducing and if-clause. For example, we can return the above string if we detect the artifacory backend (as returned by audb.Repository.backend) and return just the name otherwise:

'data-public'

@ChristianGeng any thoughts on this?

@hagenw hagenw changed the title Support Dataset.repository link on all backends Support Dataset.repository_link on all backends Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant