Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase safety checks in initialisation code #14

Open
Ivan-Velickovic opened this issue Oct 11, 2024 · 1 comment
Open

Increase safety checks in initialisation code #14

Ivan-Velickovic opened this issue Oct 11, 2024 · 1 comment

Comments

@Ivan-Velickovic
Copy link
Contributor

While integrating the FATFS code I have found it easy to make hard-to-debug mistakes with the initialisation of cothreads, particularly around either getting stack pointers wrong or passing in the wrong number of stacks for how many cothreads exist.

These issues can be easy to make but quite difficult to debug, it would help to have some more debug checks that validate that the stacks provided are accessible and don't cause faults etc.

@Ivan-Velickovic
Copy link
Contributor Author

Ivan-Velickovic commented Jan 10, 2025

More concrete things to check:

  • check for null pointers in stack_ptrs_arg_array_t.
  • overflow should be checked first before trying to access the stacks
  • alignment of stacks should be checked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant