Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

ERB files grammar is not correct #203

Open
1 task done
deiga opened this issue Jun 25, 2017 · 0 comments
Open
1 task done

ERB files grammar is not correct #203

deiga opened this issue Jun 25, 2017 · 0 comments
Labels

Comments

@deiga
Copy link

deiga commented Jun 25, 2017

Prerequisites

Description

PR #181 introduced a very subtle bug, which can't be reproduced other than in a very controller environment

Steps to Reproduce

  1. Disable package language-ruby-on-rails
  2. Reload editor
  3. Open a file with a plain .erb extension
  4. Set syntax to Auto Detect

Expected behavior:
File syntax should be Ruby or Embedded Ruby or something and scope should be source.ruby.embedded or something

Actual behavior:
Syntax is Plain Text and scope is text.plain.null-grammar

Reproduces how often:

100%

Versions

Atom: 1.18.0
Electron: 1.3.15
apm: 1.18.1
macOS 10.12.5

Additional Information

It seems that removing erb from HTML (Ruby - ERB) grammar left a hole where there is no actual grammar for .erb files defined

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants